Skip to content

Added Fixed Zoom Levels - #165

Open
cs-mt wants to merge 5 commits into
sylikc:masterfrom
cs-mt:master
Open

Added Fixed Zoom Levels#165
cs-mt wants to merge 5 commits into
sylikc:masterfrom
cs-mt:master

Conversation

@cs-mt

@cs-mt cs-mt commented Mar 5, 2023

Copy link
Copy Markdown

Hi. I made changes so that the zoom-ins and zoom-outs made using the mouse scroll would have fixed percentages between 3% and 500%. It defaults to the previous exponent calculation outside of these levels. These levels are fixed in the code, but this can be made into a setting so that users can have their own fixed sizes.

@sylikc sylikc added enhancement New feature or request config opts Related to configuration options, config files, or keymap files labels Mar 5, 2023
@sylikc

sylikc commented Mar 5, 2023

Copy link
Copy Markdown
Owner

Interesting... looks even better now that it's configurable. Give me a few days to run it through the debugger and get this tested. After having messed with zoom so much for the last release I want to see if there's any bugs in the actual zoom portion of the code.

How does it handle it now when the zoom step exceeds the maximum allowed for that image, and it "snaps back" to the % that's currently allowed? Does it try again to zoom to that at the next try?

Comment thread src/JPEGView/SettingsProvider.cpp
Comment thread src/JPEGView/SettingsProvider.cpp Outdated
Comment thread src/JPEGView/SettingsProvider.cpp Outdated
Comment thread src/JPEGView/SettingsProvider.cpp
Comment thread src/JPEGView/SettingsProvider.h Outdated
Comment thread src/JPEGView/SettingsProvider.h Outdated
@cs-mt

cs-mt commented Mar 5, 2023

Copy link
Copy Markdown
Author

Interesting... looks even better now that it's configurable. Give me a few days to run it through the debugger and get this tested. After having messed with zoom so much for the last release I want to see if there's any bugs in the actual zoom portion of the code.

How does it handle it now when the zoom step exceeds the maximum allowed for that image, and it "snaps back" to the % that's currently allowed? Does it try again to zoom to that at the next try?

If the zoom step is outside of the defined range, it defaults to the exponent calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config opts Related to configuration options, config files, or keymap files enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants