Add ember#263
Draft
NullVoxPopuli wants to merge 5 commits intosxzz:mainfrom
Draft
Conversation
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Apr 30, 2026
camc314
added a commit
to oxc-project/oxc
that referenced
this pull request
May 1, 2026
Fixes #21995 Unblocks - sxzz/ast-explorer#263 Why? - getting the actual list of visitorKeys provides an optimization for tools like zimmerframe, which will `walk` over only the things specified in the visitorKeys list -- helping prevent accidental recursive visiting, which can happen when a tree adds parent referencs Co-authored-by: Cameron <cameron.clark@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an ember parser, following the example of svelte and astro (since astro also has a wasm part of its parser)
Note
Currently, this is still in the "trying to" phase, because content-tag and oxc-parser are wasm-providing packages, and are dependencies of ember-estree, and it seems jsdeliver is breakin on this somehow?
My debugging journey: https://discord.com/channels/480462759797063690/717767358743183412/1499455777151123588
(in the ember discord server, https://discord.gg/emberjs)
Dependents before this ast-explorer PR can be ready for review:
visitorKeysfromwasmentrypoint oxc-project/oxc#21996Linked Issues
Additional context
Uses ember-estree, which is the ember-ecosystem's first combined AST (JS/TS + template) library -- it is fairly recent, but it's something that I probably should have done years ago (I guess I probably hoped someone else would have done it by now haha).