Conversation
| interactive = False | ||
| verbose = False | ||
| ssl_insecure = False | ||
| non_persistent = False # Disables keep-alive pycurl option |
There was a problem hiding this comment.
Would be nice to specify testing -vs- benchmarking here. Not sure how hard that would be though.
CodeMonk
left a comment
CodeMonk
left a comment
There was a problem hiding this comment.
While this absolutely fixes an issue I'm seeing with django2 (http/1.1), should the fix be hidden behind a command line flag, or, does pycurl's reuse make the old reuse simply redundant?
|
Actually, the latest version of pycurl already takes care of handle reuse on its own by resetting instead of closing, the explicit handle reuse in the framework is no longer necessary and, in my personal opinion, confusing - simple is better than complex, right? -, now, in regards to tcp persistent connections I rather this to be optional to avoid issues in very complicated use cases - don't want to ruin it for anyone else. |
3 participants
Added an option to disable persistent connections in order to avoid issues with Django