fix: decode error on refund response - #309
Closed
potibm wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Hi @matoous. Thanks for taking care! Should have taken a closer look at CONTRIBUTING.md :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an unmarshaling error that happens when the Refund endpoint returns an empty
{}body.I just changed the code to decode into a standard
json.RawMessagefirst. Now it works perfectly on my end.As mentioned in the issue #308 , there are a few other types in
checkouts.goandcustomers.gothat might need a similar adjustment, but I only touched the Refund endpoint for now to get it working again.