Skip to content

550 Replace scrapbook with symfony cache#439

Open
absumo wants to merge 1 commit intomasterfrom
550-replace-scrapbook
Open

550 Replace scrapbook with symfony cache#439
absumo wants to merge 1 commit intomasterfrom
550-replace-scrapbook

Conversation

@absumo
Copy link
Copy Markdown

@absumo absumo commented Apr 10, 2026

Summary by Sourcery

Replace the custom Scrapbook-based caching setup with Symfony’s native cache component across configuration, tests, and dependencies.

Enhancements:

  • Configure a Symfony cache pool service using the framework cache.app adapter for application-wide caching.
  • Update module settings tests to use Symfony's ArrayAdapter cache implementation instead of Scrapbook classes.

Build:

  • Remove the matthiasmullie/scrapbook dependency and add symfony/cache to composer requirements.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 10, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces the custom Scrapbook-based cache implementation with Symfony Cache, wiring a new cache pool service and updating tests and dependencies accordingly.

File-Level Changes

Change Details Files
Replace custom Scrapbook-based cache pool with Symfony Cache pool configuration.
  • Configure a new framework.cache pool service using the cache.app adapter and mark it public
  • Remove the custom Flysystem/Scrapbook-based cache adapter, buffered store, and PSR-6 pool service definitions from the service container
app/config/config.yml
Update module settings tests to use Symfony ArrayAdapter instead of Scrapbook pool implementation.
  • Replace Scrapbook MemoryStore and Psr6 Pool usage with Symfony\Component\Cache\Adapter\ArrayAdapter when constructing ModulesSettings in tests
  • Remove unused Scrapbook imports and add import for Symfony ArrayAdapter
src/Common/Tests/ModulesSettingsTest.php
Adjust Composer dependencies to drop Scrapbook and add Symfony Cache.
  • Remove matthiasmullie/scrapbook from production dependencies
  • Add symfony/cache as a required dependency alongside existing Symfony components
composer.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant