Skip to content

557 Show detail button for items in media library #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
absumo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

557 Show detail button for items in media library #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/Backend/Modules/MediaLibrary/Domain/MediaItem/MediaItemDataGrid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@ public function __construct(Type $type, ?int $folderId = null, ?string $searchQu
$this->getParameters($type, $folderId, $searchQuery)
);

$this->addColumn('detail');
$this->setColumnFunction(
[__CLASS__, 'getDetailUrl'],
['[sharding_folder_name]', '[url]', '[storage_type]'],
'detail'
);

// filter on folder?
if ($folderId !== null) {
$this->setURL('&folder=' . $folderId, true);
Expand Down Expand Up @@ -212,4 +219,21 @@ private function setExtras(Type $type, ?int $folderId = null): void
$this->setRowAttributes(['id' => 'row-[id]']);
$this->setColumnFunction('htmlspecialchars', ['[title]'], 'title', false);
}

public static function getDetailUrl(string $shardingFolderName, string $url, string $storageType): string
{
if ($storageType === 'youtube') {
$link = 'https://youtube.com/watch?v=' . $url;
} elseif ($storageType === 'vimeo') {
Comment thread
tijsverkoyen marked this conversation as resolved.
$link = 'https://www.vimeo.com/' . $url;
} else {
$link = '/src/Frontend/Files/MediaLibrary/' . $shardingFolderName . '/' . $url;
}
Comment on lines +225 to +231
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider using a generated/public-facing URL instead of a hard-coded path into src/Frontend.

Hard-coding /src/Frontend/Files/MediaLibrary/ couples this link to the current directory structure and will likely break if the public path or deployment layout changes. Prefer using an existing helper/config value to build media URLs (or adding one if missing) instead of embedding the path directly.

Suggested change
if ($storageType === 'youtube') {
$link = 'https://youtube.com/watch?v=' . $url;
} elseif ($storageType === 'vimeo') {
$link = 'https://www.vimeo.com/' . $url;
} else {
$link = '/src/Frontend/Files/MediaLibrary/' . $shardingFolderName . '/' . $url;
}
if ($storageType === 'youtube') {
$link = 'https://youtube.com/watch?v=' . $url;
} elseif ($storageType === 'vimeo') {
$link = 'https://www.vimeo.com/' . $url;
} else {
$link = FRONTEND_FILES_URL . '/MediaLibrary/' . $shardingFolderName . '/' . $url;
}


$html = '<a href="' . $link . '" target="_blank" class="btn btn-default btn-xs pull-right">';
$html .= '<span class="fa fa-eye"></span>' . ucfirst(Language::lbl('View'));
$html .= '</a>';

return $html;
}
}
Loading