fix(cli): raise error for unrecognized root flags like --group#207
Open
panther-0707 wants to merge 1 commit into
Open
fix(cli): raise error for unrecognized root flags like --group#207panther-0707 wants to merge 1 commit into
panther-0707 wants to merge 1 commit into
Conversation
|
This pull request has been marked as stale because it has been |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #206
Previously, passing an unknown flag such as
--groupbefore asubcommand would silently break out of the argument parsing loop
in
extract_root_config(). This caused Sugar to fall back toenvironment variable defaults, affecting unintended containers
with no warning shown to the user.
Changes
extract_root_config()for unrecognized flagsstarting with
----profileas the correctparameter
How to Test
Pull Request checklist