strip whitespace from comma-separated service names#205
Open
AnshulPatil2005 wants to merge 1 commit into
Open
Conversation
Author
|
@sanjay7178 @xmnlab Could you please review this PR when you get a chance. Thanks. |
|
This pull request has been marked as stale because it has been |
xmnlab
requested changes
Mar 27, 2026
xmnlab
left a comment
xmnlab
left a comment
Contributor
There was a problem hiding this comment.
Just a small issue with the claude code
Other than that it is ready to go
| @@ -0,0 +1,10 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Please don't push claude files
|
This pull request has been marked as stale because it has been |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request description
Fixes a bug where passing service names with spaces after commas (e.g.
--services "service1, service2") would silently fail to match services. The space was being included as part of the service name, causing mismatches.Root cause:
_arg_services.split(',')in_get_services_namesdid not strip whitespace from each element.Fix: Changed to
[s.strip() for s in _arg_services.split(',')]insrc/sugar/extensions/base.py.solve #204
How to test these changes
run test
pytest tests/test_ext_compose.py::test_cmd_build_services_with_spacesPull Request checklists
This PR is a:
About this PR:
Author's checklist:
complexity.
Additional information
Before fix:
"service1, service2".split(',')→['service1', ' service2']— the leading space onservice2causes a lookup failure.After fix:
[s.strip() for s in "service1, service2".split(',')]→['service1', 'service2']— correct.Changed file:
src/sugar/extensions/base.pyline 436.Test added:
tests/test_ext_compose.py::test_cmd_build_services_with_spaces.