What is your take on ImagePackage for collab?#2
Open
solsson wants to merge 3 commits into
Open
Conversation
... not great. As images go collab the other clients say "TypeError: Argument 1 is not valid for any of the 2-argument overloads of URL.createObjectURL." Save button doesn't get enabled upon edit.
such as a REST endpoint that fetches content from collab server's document API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when an image is added through file selection, other clients get an immediate error with
URL.createObjectURL. I'm assuming it would be a bad idea to try to send serialized images over the websockets connection, as they can be very large.With a FileProxy in place the image node would still be distributed before there is time to upload and produce a real external URL.
Is there already a mechanism for images in collab? If not, how would you suggest this is done?