Skip to content

fix: escape challenge header values #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emmajam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: escape challenge header values #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/com/stripe/mpp/Parsing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@ static Map<String, String> parseAuthParams(String input) {
}

private static String quote(String value) {
return "\"" + value + "\"";
if (value.indexOf('\r') >= 0 || value.indexOf('\n') >= 0) {
throw new IllegalArgumentException("Header values must not contain CR or LF");
}
return "\"" + value.replace("\\", "\\\\").replace("\"", "\\\"") + "\"";
}

// --- WWW-Authenticate (Challenge) ---
Expand Down
36 changes: 36 additions & 0 deletions src/test/java/com/stripe/mpp/ParsingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,42 @@ void challengeFromWwwAuthenticateHandlesMultipleSchemes() {
assertThat(challenges.get(0).id()).isEqualTo("abc");
}

@Test
void challengeEscapesQuotedStringDescription() {
Challenge original = Challenge.create("secret", "example.com", "tempo", "charge", Map.of(),
null, "Pay \"premium\" API", null);

String header = original.toWwwAuthenticate();

assertThat(header).contains("description=\"Pay \\\"premium\\\" API\"");
var parsed = Challenge.fromWwwAuthenticate(header);
assertThat(parsed).hasSize(1);
assertThat(parsed.get(0).description()).isEqualTo("Pay \"premium\" API");
}

@Test
void challengeEscapesBackslashDescription() {
Challenge original = Challenge.create("secret", "example.com", "tempo", "charge", Map.of(),
null, "Path C:\\tempo\\api", null);

String header = original.toWwwAuthenticate();

assertThat(header).contains("description=\"Path C:\\\\tempo\\\\api\"");
var parsed = Challenge.fromWwwAuthenticate(header);
assertThat(parsed).hasSize(1);
assertThat(parsed.get(0).description()).isEqualTo("Path C:\\tempo\\api");
}

@Test
void challengeRejectsCrlfDescription() {
Challenge challenge = Challenge.create("secret", "example.com", "tempo", "charge", Map.of(),
null, "Line one\r\nLine two", null);

assertThatThrownBy(challenge::toWwwAuthenticate)
.isInstanceOf(IllegalArgumentException.class)
.hasMessageContaining("CR or LF");
}

// --- Credential (Authorization) ---

@Test
Expand Down