Skip to content

Issue stratisd 3597#1257

Draft
mulkieran wants to merge 15 commits intostratis-storage:masterfrom
mulkieran:issue-stratisd-3597
Draft

Issue stratisd 3597#1257
mulkieran wants to merge 15 commits intostratis-storage:masterfrom
mulkieran:issue-stratisd-3597

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Jan 15, 2026

No description provided.

@packit-as-a-service
Copy link

packit-as-a-service bot commented Jan 15, 2026

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/stratis-storage-stratis-cli-1257-copr_pull
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch 2 times, most recently from d535137 to b3e85bf Compare January 15, 2026 17:18
@mulkieran
Copy link
Member Author

mulkieran commented Jan 15, 2026 •
edited
Loading

Right now, we do have the option of making the timeout shorter for our long-running operations than for our other operations. The best way to do this properly is to import only the methods we need in building the dbus-python-client-gen methods and do it exactly where the methods are used. We could still use the public make_class method, but modify the spec file passed to it.

@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch from 816930b to 04dfaf9 Compare January 15, 2026 18:40
@mulkieran
Copy link
Member Author

mulkieran commented Jan 16, 2026

Long running operation decorator needs to specify the function that is allowed to run for a long time. Otherwise, if it's GetManagedObjects that is the long-running function, "Operation initiated" may be erroneously returned. Should allow it to take a list argument, just to be on the safe side.

@jbaublitz
Copy link
Member

jbaublitz commented Jan 16, 2026

Just one observation: I don't think GetManagedObjects every can be the long-running operation in the current state of stratisd but I'm aware that could change in the future with changes to our locking.

@mulkieran
Copy link
Member Author

mulkieran commented Jan 16, 2026 •
edited
Loading

Just one observation: I don't think GetManagedObjects every can be the long-running operation in the current state of stratisd but I'm aware that could change in the future with changes to our locking.

In a bunch of method we call GetManagedObjects() first and then, e.g., EncryptPool. If GetManagedObjects is the method that times out, we need to treat that as an actual timeout..., with the non-specific decorator on the Python methods stratis-cli is reporting "Operation initiated" on a GetManagedObjects timeout, which is wrong. That's what needs to be fixed.

@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch from fbae33b to 44a7c56 Compare January 16, 2026 16:10
@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch from 44a7c56 to 2c7de08 Compare January 25, 2026 23:39
@mulkieran mulkieran mentioned this pull request Jan 26, 2026
Merged
@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch from f5b8dc0 to 7548550 Compare January 28, 2026 18:11
@mulkieran mulkieran mentioned this pull request Jan 28, 2026
Merged
@mulkieran
Copy link
Member Author

mulkieran commented Jan 28, 2026

I do not know why building stratisd man pages was failing...but we do not need those pages built to test stratisd, so I'm just fixing that in the most basic way.

@mulkieran
Only match org.freedesktop.zbus.Error for property setting
0bb37de 
At present, the zbus D-Bus error is the only error that can be returned
when setting a property.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch from 7548550 to 4f0ec4c Compare January 28, 2026 20:37
@mulkieran mulkieran self-assigned this Jan 28, 2026
@mulkieran mulkieran added this to the v3.9.0 milestone Jan 28, 2026
@mulkieran mulkieran moved this to In Progress in 2026January Jan 28, 2026
@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch 2 times, most recently from 7826449 to db3c0ab Compare January 29, 2026 14:55
@mulkieran
Copy link
Member Author

mulkieran commented Jan 29, 2026

Ok. Redirects are working....

@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch 3 times, most recently from 62146b1 to b635291 Compare January 29, 2026 18:06
@mulkieran
Copy link
Member Author

mulkieran commented Jan 29, 2026

Works again...

@mulkieran mulkieran moved this from In Progress to In Review in 2026January Jan 29, 2026
@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch from b635291 to b1da778 Compare January 29, 2026 23:36
@mulkieran
Update introspection data
8829b94 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Set up clevis + keyring options for sharing
eaf96a3 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Add commands for encrypt, re-encrypt, and unencrypt
007d568 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Test parsing clevis options in encryption on
af36597 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Add an --in-place option
d47e71f 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Half D-Bus timeout
3fc33e2 
We had it as high as two minutes to give a chance of returning on fairly
long-running task, like creating encrypted pools, since each device had
to be separately encrypted. We do not do that anymore, as the whole pool
is encrypted these days, so the create method returns faster.

We are about to introduce really long running commands, where 120
minutes will not be enough in almost all cases.

So shortening the D-Bus timeout seems like a reasonable thing to do.

60 seconds is a plenty long time to wait for any error messsages that
stratisd might return.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Add a decorator for our long running operations
aceb745 
This way we can relatively cheaply avoid printing the timeout error
message and return a zero exit code on the timeout.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Display last time re-encrypted in pool detail view
0a98f14 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Add man page entries for the moved subcommands
2a0b252 
These are bind, unbind, and rebind. The new commands use the
mandatory --name, --uuid option mechanism for specifying the pool to
operate on, while the old commands just used name.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
man: Add entries for encryption on, off, and re-encrypt
8533131 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
man: Add entry for the "Last Time Reencrypted" field
bf16022 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch from b1da778 to 9f0dde8 Compare January 29, 2026 23:43
@mulkieran
Time out after ten seconds for long-running methods
800635a 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
TEMPORARY: remove manual trigger
bc89637 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
TEMPORARY: Redirect dbus-python-client-gen repos to master
a68cb52 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch from 9f0dde8 to a68cb52 Compare January 29, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mulkieran mulkieran

Labels

None yet

Projects

2026January
Status: In Review

Milestone

v3.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mulkieran @jbaublitz