Skip to content

chore: add Git note for broken commit message#12094

Merged
kgryte merged 1 commit into
developfrom
philipp/fix-git-notes-4ba2886
May 11, 2026
Merged

chore: add Git note for broken commit message#12094
kgryte merged 1 commit into
developfrom
philipp/fix-git-notes-4ba2886

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Resolves stdlib-js/todo#2478.

Description

What is the purpose of this pull request?

This pull request:

  • adds a Git note (amend-message) for merge commit 4ba28863d5a10526febd508b7a955babcd74f8e0 to rewrite the subject from feat!: migrate ... to Merge pull request #5116 from gururaj1512/migrate-math-base-ops-add3, so that changelog tooling skips the merge commit. The actual commit history from PR feat!: migrate math/base/ops/add3 to number/float64/base/add3 #5116 is preserved on the merged branch.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • stdlib-js/todo#2478

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written by Claude Code.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label May 11, 2026
@Planeshifter Planeshifter marked this pull request as ready for review May 11, 2026 05:24
@Planeshifter Planeshifter requested review from a team and kgryte May 11, 2026 05:24
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 11, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 11, 2026
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kgryte kgryte merged commit 6caf672 into develop May 11, 2026
51 checks passed
@kgryte kgryte deleted the philipp/fix-git-notes-4ba2886 branch May 11, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants