feat: add blas/ext/base/clast-index-of-row#12029
Merged
Merged
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: missing_dependencies
- task: lint_c_examples
status: missing_dependencies
- task: lint_c_benchmarks
status: missing_dependencies
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
stdlib-bot
added
BLAS
headlessNode
added
Feature
Contributor
Coverage ReportNo coverage information available. |
kgryte
reviewed
May 11, 2026
kgryte
reviewed
May 11, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
May 11, 2026
kgryte
reviewed
May 11, 2026
kgryte
reviewed
May 11, 2026
Member
Author
|
@kgryte Here |
kgryte
requested changes
May 11, 2026
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
Apart from the benchmarks, this is looking good.
kgryte
added
Needs Changes
Member
You're right. I retract my comment. Thanks for pointing that out. |
kgryte
added
review: 4
and removed
Needs Changes
kgryte
reviewed
May 12, 2026
| workspace = zeros( N, 'uint8' ); | ||
| abuf = uniform( N*N*2, -100.0, 100.0, options ); | ||
| A = new Complex64Array( abuf.buffer ); | ||
| xbuf = uniform( N*2, 200.0, 300.0, options ); |
Member
There was a problem hiding this comment.
For the record, these benchmark values are not the best, as they are not actually testing the worst-case scenario, which is when the last N-1 values match for every row, but the first element on each row differs from the corresponding element in the search vector.
Deriving the worst-case scenario requires knowing implementation details, which is also not ideal.
We can get this in as is, but it is something you should keep in mind going forward when designing benchmarks. Trivial cases are not particularly interesting from a measurement perspective, as they don't actually give us much signal in terms of the implementation and its behavior.
kgryte
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves stdlib-js/metr-issue-tracker#339.
Description
This pull request:
blas/ext/base/clast-index-of-rowRelated Issues
This pull request has the following related issues:
blas/ext/base/clast-index-of-rowmetr-issue-tracker#339Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Primarily written by Claude Code.
@stdlib-js/reviewers