Skip to content

feat: add blas/base/zgemv#10237

Open
Om-A-osc wants to merge 12 commits into
stdlib-js:developfrom
Om-A-osc:feat/blas-base-zgemv
Open

feat: add blas/base/zgemv#10237
Om-A-osc wants to merge 12 commits into
stdlib-js:developfrom
Om-A-osc:feat/blas-base-zgemv

Conversation

@Om-A-osc
Copy link
Copy Markdown
Contributor

@Om-A-osc Om-A-osc commented Feb 12, 2026


type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

  • task: lint_filenames
    status: passed
  • task: lint_editorconfig
    status: passed
  • task: lint_markdown
    status: passed
  • task: lint_package_json
    status: passed
  • task: lint_repl_help
    status: na
  • task: lint_javascript_src
    status: passed
  • task: lint_javascript_cli
    status: na
  • task: lint_javascript_examples
    status: passed
  • task: lint_javascript_tests
    status: passed
  • task: lint_javascript_benchmarks
    status: passed
  • task: lint_python
    status: na
  • task: lint_r
    status: na
  • task: lint_c_src
    status: passed
  • task: lint_c_examples
    status: na
  • task: lint_c_benchmarks
    status: na
  • task: lint_c_tests_fixtures
    status: na
  • task: lint_shell
    status: na
  • task: lint_typescript_declarations
    status: passed
  • task: lint_typescript_tests
    status: na
  • task: lint_license_headers
    status: passed

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request:

  • Adds the implementation for blas/base/zgemv.
  • Adds comprehensive tests covering multiple edge cases, including different transpose modes, stride variations, and boundary conditions.
  • Ensures consistency with BLAS level 2 specifications and existing stdlib BLAS modules.

Related Issues

Does this pull request have any related issues?

This pull request progresses:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The implementation follows the structure and conventions used in other BLAS level 2 modules within the repository to maintain consistency.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

Disclosure

N/A.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Feb 12, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 12, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/base/zgemv $\color{green}586/586$
$\color{green}+0.24%$
$\color{green}80/80$
$\color{green}+0.86%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}586/586$
$\color{green}+0.24%$

The above coverage report was generated for the changes in this PR.

@Om-A-osc Om-A-osc marked this pull request as draft February 12, 2026 14:01
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 12, 2026
@Om-A-osc Om-A-osc force-pushed the feat/blas-base-zgemv branch from 092f272 to 1528b83 Compare February 12, 2026 18:00
@Om-A-osc
Copy link
Copy Markdown
Contributor Author

failing run_affected_benchmarks CI check depends on #10235.
@kgryte @Planeshifter Please review this.

@Om-A-osc Om-A-osc marked this pull request as ready for review February 12, 2026 18:10
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 12, 2026
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a massive PR!

Comment thread lib/node_modules/@stdlib/blas/base/zgemv/manifest.json Outdated
Comment thread lib/node_modules/@stdlib/blas/base/zgemv/benchmark/benchmark.ndarray.js Outdated
Comment thread lib/node_modules/@stdlib/blas/base/zgemv/examples/index.js Outdated
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 12, 2026
@Om-A-osc
Copy link
Copy Markdown
Contributor Author

@Planeshifter addressed previous comments.

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 15, 2026
Om-A-osc and others added 10 commits May 11, 2026 10:39
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@MeKaustubh07 MeKaustubh07 force-pushed the feat/blas-base-zgemv branch from 6ff5c22 to e816e5d Compare May 11, 2026 17:13
@MeKaustubh07 MeKaustubh07 requested a review from a team May 11, 2026 17:13
@MeKaustubh07 MeKaustubh07 changed the title feat: add implementation for blas/base/zgemv feat: add blas/base/zgemv May 11, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented May 12, 2026

@MeKaustubh07 You requested a review, but CI is still failing. You'll want to resolve CI failures first. I would think this package should be straightforward to implement given that we already have cgemv, making this package a copy, paste, and modify to double-precision.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 12, 2026
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label May 12, 2026
@MeKaustubh07
Copy link
Copy Markdown
Member

@MeKaustubh07 You requested a review, but CI is still failing. You'll want to resolve CI failures first. I would think this package should be straightforward to implement given that we already have cgemv, making this package a copy, paste, and modify to double-precision.

@kgryte This PR is still a WIP, apologies for the early review ping.
Yeah The JavaScript-side implementation has been fairly straightforward so far but, I still need to complete and align the corresponding C implementation and resolve the remaining CI issues.
I’ll update the PR and request a review again once those changes are in place.

@MeKaustubh07
Copy link
Copy Markdown
Member

@kgryte We might want to review #11739 first, as it would likely be less time-consuming on your end, and I can mirror any remaining minor changes from there if needed after updating the whole zgemv.

@MeKaustubh07 MeKaustubh07 mentioned this pull request May 12, 2026
1 task
@MeKaustubh07 MeKaustubh07 marked this pull request as draft May 12, 2026 07:28
@MeKaustubh07 MeKaustubh07 marked this pull request as ready for review May 12, 2026 18:52
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 12, 2026
@MeKaustubh07 MeKaustubh07 requested a review from kgryte May 12, 2026 18:53
@MeKaustubh07 MeKaustubh07 removed the Needs Changes Pull request which needs changes before being merged. label May 12, 2026
@MeKaustubh07
Copy link
Copy Markdown
Member

@kgryte Done with the refactoring, ready for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants