Skip to content

Incorporate improvements from @soshial/@tripplet + myself#151

Closed
ndoo wants to merge 28 commits into
stanleyhuangyc:masterfrom
ndoo:master
Closed

Incorporate improvements from @soshial/@tripplet + myself#151
ndoo wants to merge 28 commits into
stanleyhuangyc:masterfrom
ndoo:master

Conversation

@ndoo

@ndoo ndoo commented Jan 12, 2022

Copy link
Copy Markdown

Merged a bunch of improvements/fixes from soshial@, and cherry-picked improvements/fixes from tripplet. Added some improvements of my own. Please refer to commits for specifics. Review/feedback welcome.

Duplicates:

Apologies for raising a large PR, but hopefully I was able to add some value, as I have compile-tested and fuctionality-tested the changes on my Freematics ONE+ model B.

soshial and others added 28 commits June 6, 2021 15:43
elaborate differences between protocols

@SpaceCat101 SpaceCat101 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So after changing the volume and frequency (Freematics.cpp), how can I customize it? It sounds the same to me.

@ndoo

ndoo commented Mar 29, 2022

Copy link
Copy Markdown
Author

So after changing the volume and frequency (Freematics.cpp), how can I customize it? It sounds the same to me.

Hi there, this is implemented in 51c2548 - telelogger v5: Add customizable startup beep sequence:

The configuration needed is documented in config.h:

#define BEEP_TABLE {2000} /* Hz, each value is a 100ms cycle (use "0" to add gaps) */

E.g.:

#define BEEP_TABLE {1000, 0, 2000, 0, 4000} /* Hz, each value is a 100ms cycle (use "0" to add gaps) */

@SpaceCat101 SpaceCat101 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
With this code how are we suppose to control the buzzer? Is the original volume the loudest already?

@ndoo

ndoo commented Apr 11, 2022

Copy link
Copy Markdown
Author

Hi, With this code how are we suppose to control the buzzer? Is the original volume the loudest already?

Hi, volume control is out of scope of this PR. The original volume is the loudest possible already.

@SpaceCat101

Copy link
Copy Markdown

Hi,
Do you have any clue how I can adjust the volume of the buzzer?

@ndoo ndoo closed this Feb 4, 2024
@PilaScat

Copy link
Copy Markdown

Is possibile to manually merge this code? Can it work today?

@ndoo

ndoo commented May 12, 2025

Copy link
Copy Markdown
Author

With the developer/maintainer ignoring PRs for the past 5 years, what is the point?

Contact them directly, it is a waste of community effort to write code that will never get merged.

@PilaScat

Copy link
Copy Markdown

I wrote to him, in the meantime would you be so kind as to make an updated fork if it's a small thing? Because I have the new 7670 module and the other forks probably wouldn't work

@ndoo

ndoo commented May 12, 2025

Copy link
Copy Markdown
Author

I wrote to him, in the meantime would you be so kind as to make an updated fork if it's a small thing? Because I have the new 7670 module and the other forks probably wouldn't work

Sorry, it's too much work as the code base has already diverged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants