Allow public GitHub issue reads without token#2774
Open
cybercraftsolutionsllc wants to merge 1 commit into
Open
Allow public GitHub issue reads without token#2774cybercraftsolutionsllc wants to merge 1 commit into
cybercraftsolutionsllc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #743.
Summary
GITHUB_TOKENis not configured.Why
Public GitHub issue reads should not require a configured token. The old client always wrapped requests in OAuth even when
GITHUB_TOKENwas empty, which can cause GitHub to reject public issue lookups as bad credentials and surface as "make sure the repo is public" style failures.Validation
go test handlers/github.go handlers/github_test.gogit diff --checkNote:
go test ./handlers -run 'TestGithubClientWithToken|TestGetGithubIssue'is currently blocked by existing generated mock drift in unrelated handler tests:mocks.Databaseis missingGetBountyByUnlockCode.