Resolve flakiness#7262
Merged
brice-stacks merged 2 commits intoJun 2, 2026
Merged
Conversation
`get_unconfirmed_tx` returns `None` on any non-success response, including transient RPC errors while the node is busy processing a block. Asserting on a single request immediately after submitting `tx_high` races with that block processing and flakes under active mining. Poll with `wait_for` instead of asserting on a single request. This is strictly stronger: it still requires the tx to become visible in the mempool, but tolerates the transient window before it is queryable.
The test waited for the block-commit *count* to increase after a config change, then asserted the last commit amount equalled the new burn fee cap. But the miner submits an RBF commit every initiative, so an old-config commit submitted between the snapshot and the config reload satisfies the count-based wait while still carrying the old amount, flaking `assert_eq!(commit_amount_after, 155000)`. Wait for a commit reflecting the new config (amount == 155000) instead.
Coverage Report for CI Build 26782862059Coverage increased (+0.04%) to 85.752%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions6681 previously-covered lines in 120 files lost coverage.
Coverage Stats
💛 - Coveralls |
francesco-stacks
approved these changes
Jun 2, 2026
federico-stacks
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes two newly identified sources of flakiness.