Conversation
|
Skipping CI for Draft Pull Request. |
github-actions
bot
added
area/ci
konflux-build
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
/konflux-retest <job>-on-pushpattern is duplicated across all Tekton pipeline manifests; consider centralizing this in a shared template or generator to avoid copy‑paste drift when job names change or new pipelines are added.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `/konflux-retest <job>-on-push` pattern is duplicated across all Tekton pipeline manifests; consider centralizing this in a shared template or generator to avoid copy‑paste drift when job names change or new pipelines are added.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Images are ready for the commit at 27fb4ba. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18917 +/- ##
==========================================
- Coverage 49.52% 49.51% -0.01%
==========================================
Files 2666 2670 +4
Lines 201181 201549 +368
==========================================
+ Hits 99629 99801 +172
- Misses 94115 94294 +179
- Partials 7437 7454 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest scanner-v4-db-on-push |
|
/retest operator-bundle-on-push |
|
/retest scanner-v4-db-on-push |
|
/retest main-on-push |
1 similar comment
|
/retest main-on-push |
|
/retest operator-bundle-on-push |
|
/konflux-retest scanner-v4-db-on-push |
|
/retest scanner-v4-db-on-push |
|
/retest central-db-on-push |
|
/retest main-on-push |
|
/retest operator-bundle-on-push |
| pipelinesascode.tekton.dev/on-comment: "/konflux-retest scanner-v4-db-on-push" | ||
| # TODO(ROX-21073): re-enable for all PR branches | ||
| pipelinesascode.tekton.dev/on-cel-expression: | | ||
| ( |
There was a problem hiding this comment.
(Not about this line and sorry I just realized.) Retag pipelines don't get this /konflux-retest thingy because they aren't recognized by konflux-auto-retest workflow? Maybe that's a gap in konflux-auto-retest to address.
In the mean time, I suggest adding pipelinesascode.tekton.dev/on-comment there too for consistency. If engineers learn something cool, they'd want to use it everywhere. It will be disappointing if we support that only in the few places.
Same about the create-custom-snapshot pipeline.
There was a problem hiding this comment.
You are right, that's a direction to improve konflux retest. It was done in a way to support only specific suffix but it will be much more convinient to just provide a list of konflux pipeline names which should be retested
Added pipelinesascode.tekton.dev/on-comment to retag and create-custom-snapshot pipelines
| with: | ||
| max_retries: 3 | ||
| check_name_suffix: '-on-push' | ||
| retest_command: '/konflux-retest' |
There was a problem hiding this comment.
Will this be effective only for the master branch once this PR is merged or will auto-retester attempt to use /konflux-retest comments on release-* branches also?
There was a problem hiding this comment.
When it will be in the master branch then all PRs will be covered regardless, including already opened PRs
There was a problem hiding this comment.
Unfortunately already opened PRs will need a rebase
There was a problem hiding this comment.
Sorry, I don't understand your reply. Let me try ask it differently.
This PR open is against master and so this change lands onto master. The consequences are clear to me, no questions there.
The question is about release-* branches. Will the GHA workflow for .github/workflows/konflux-auto-retest.yml from the master branch be used in PRs open against release-* branches? What about push commits to release-* branches?
There was a problem hiding this comment.
Yes, the .github/workflows/konflux-auto-retest.yml from the master will be applied in all PRs. However PRs might have old branch where /konflux-retest is not a known alias
There was a problem hiding this comment.
I want to double-double check that we're on the same page. When you write all PRs in
Yes, the .github/workflows/konflux-auto-retest.yml from the master will be applied in all PRs.
do you also mean PRs that have release-4.10 as target/base branch and not just master?
| with: | ||
| max_retries: 3 | ||
| check_name_suffix: '-on-push' | ||
| retest_command: '/konflux-retest' |
There was a problem hiding this comment.
Sorry, I don't understand your reply. Let me try ask it differently.
This PR open is against master and so this change lands onto master. The consequences are clear to me, no questions there.
The question is about release-* branches. Will the GHA workflow for .github/workflows/konflux-auto-retest.yml from the master branch be used in PRs open against release-* branches? What about push commits to release-* branches?
3 participants
Description
Set konflux retest command override to avoid getting spammed by openshift-ci when konflux retest command invoked. The
/retest <konflux-pipeline>will still work as before.Github workflow changes do not have effect until it's merged to the default branch. See testing PR below to see how these changes work.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
See testing PR where this alias is merged to the default branch: stackrox/acs-fleet-manager#2573
Also tested that existing CEL conditions work as expected
I've used kubearchive for fetching pipelineruns and search was baed on commit + branch