build: set up electron-forge#51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a build system using electron-forge that bundles
thvandtoolhive-react(vite app) in an Electron App. See detailed reasoning for this: https://stacklok.slack.com/archives/C072SGY78TS/p1748880645755219Security warning
as a very temporary measure (until we have a more sophisticated data fetching configuration), web security has been disabled. This can be reverted using a single line change. More info: https://stacklok.slack.com/archives/C072SGY78TS/p1748880838175799
What's tested
I have tested build and the dev server
pnpm startlocally on Arch Linux. I have not implemented detailed configuration for any package format, I just used the default config from the template provided by Electron-forge.Running the dev server
Running the dev server now requires obtaining a
thvbinary. Currently, the easiest way to obtain that is to simply build the electron app usingpnpm run make. That will fetch an OS/processor-appropriatethvbinary for you.CI changes
Our GH Actions workflows now include a build matrix, only for the electron-forge build. Currently, the build matrix is running a build for Linux and one for Mac. We can add Windows once we have Windows support