RFC: vMCP Core Interface — Splitting Domain Logic from Transport#76
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cfadb11 to
0ca43f7
Compare
jerm-dro
approved these changes
Jun 2, 2026
jerm-dro
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Let 'er rip!
JAORMX
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposes extracting a small, identity-parameterized
VMCPdomain interface from the Virtual MCP Server, paired withNew(cfg) -> VMCPto construct the core andServe(ctx, VMCP, serverCfg) -> *Serverto stand up the transport. Embedders can wrap the core with their own decorators to augment behavior — without reimplementing aggregation/routing/composition, and without coupling to the mcp-go SDK lifecycle, the HTTP middleware chain, or request-context contracts. The existingserver.New(...)entry point is preserved as a thin wrapper overServe(ctx, New(cfg), serverCfg), so current embedders are unaffected.Key points
VMCPinterface exposing the MCP capability surface (list/call tools, list/read resources, list/get prompts, lookup) with identity as an explicit parameter — removing theauth.IdentityFromContextcoupling on the domain path.Newrelocates (not rewrites) the collaborator wiringserver.Newdoes today;Serveowns all transport concerns (mcp-go, middleware chain, embedded AS, status, telemetry, health).server.Newsignature stays stable throughout; the split lands behind it across small, sequenced PRs.🤖 Generated with Claude Code