chore(skills): harden registry review skills from PR #1243 learnings#1244
Merged
Conversation
Reviewing PR #1243 (a third-party remote server submitted into registries/official/ under a non-stacklok namespace, claiming Official tier, with a boilerplate README) surfaced gaps in the review skills. mcp-review: - Add "Registry Layout" section: toolhive/ is the contribution path, official/ is a curated subset, both normalize to io.github.stacklok. Note that task catalog:validate does not catch placement/namespace/ tier/icon convention issues. - Step 2: add location & namespace, tier-matches-maintainer, and icon convention (repo-hosted SVG + file present) checks. - Add live remote-endpoint check (initialize/tools/list handshake) so remotes are verified against their advertised tools, not the PR text. - Step 4: add repo/author maturity and documentation-relevance checks. - Add a severity rubric (Required / Expected / Weighed). add-mcp-server: - Flip remote template tier default Official -> Community and clarify in Critical Rules that Official is reserved for first-party servers. mcp-review + skill-review: - Add "Submitting the Verdict" section mapping APPROVE/REQUEST_CHANGES to gh pr review (which gates merge); note gh pr comment does not block. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Registry Build PreviewAll registries built successfully! Registry:
|
rdimitrov
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enhances the registry review/authoring skills based on concrete gaps found while reviewing #1243 (a third-party remote server submitted into
registries/official/under aio.github.bhuvanabalanamespace, claimingOfficialtier, with an unmodified Cloudflare-template README and an external PNG icon — none of whichtask catalog:validateflags).Changes
mcp-reviewtoolhive/is the contribution path,official/is a curated subset, both normalize to theio.github.stackloknamespace. Calls out thattask catalog:validatedoes not catch placement / namespace / tier-semantics / icon-host issues.icon.svgfile present; flag external icon URLs).initialize/tools/listhandshake) to verify a remote actually serves MCP and the advertisedtoolsmatch — rather than trusting the PR description.add-mcp-servertierdefault flippedOfficial→Community(the footgun that nudges third-party submissions toward the wrong tier).Officialis reserved for first-party / platform-owner servers.mcp-review+skill-reviewgh pr review(which gates the merge), and warning thatgh pr commentdoes not block.Notes
🤖 Generated with Claude Code