Document remaining medium-priority CLI gaps#939
Open
danbarr wants to merge 3 commits into
Open
Conversation
Close the medium-priority gaps from #654 that fit common workflows: - run-mcp-servers: --env-file/--env-file-dir, --publish, --foreground - manage-mcp-servers: thv status, thv logs prune, --foreground on start - secrets-management: environment secrets provider and the non-interactive thv secret provider command Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR closes the remaining medium-priority gaps in the ToolHive CLI guides by documenting previously missing but common workflow flags and commands, aligned with the gap analysis in #654.
Changes:
- Expanded the CLI secrets guide with the read-only
environmentsecrets provider (TOOLHIVE_SECRET_*) and the non-interactivethv secret providercommand. - Documented additional
thv runworkflow flags:--env-file/--env-file-dir,--publish/-p, and--foreground/-f. - Documented additional server management commands:
thv status,thv logs prune, and--foregroundonthv start.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/toolhive/guides-cli/secrets-management.mdx | Adds the environment secrets provider to the provider catalog + tabs, and documents non-interactive provider selection via thv secret provider. |
| docs/toolhive/guides-cli/run-mcp-servers.mdx | Adds missing guidance for passing env vars (including from files/dirs), publishing container ports to the host, and running in the foreground. |
| docs/toolhive/guides-cli/manage-mcp-servers.mdx | Adds documentation for detailed single-server status, pruning orphaned log files, and foreground starts for debugging. |
Apply review feedback: point readers on the Environment tab to select the provider with thv secret provider, and drop the redundant 'list' from the read-only note since listing is covered separately. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add --runtime-image and --runtime-add-package under protocol schemes in the run guide. These are thv run flags that customize the on-demand protocol-scheme build; they're not available on thv build. Corrects the misplaced build-guide section reverted from #933. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes the medium-priority CLI gaps from #654 that fit common user workflows (per the triage). Esoteric, deployment-specific flags were intentionally left undocumented.
run-mcp-servers.mdx:--env-file/--env-file-dir(load env vars from files),--publish/-p(publish a container port to the host), and--foreground/-f.manage-mcp-servers.mdx:thv status(detailed single-server status),thv logs prune(delete orphaned log files), and the--foregroundflag onthv start.secrets-management.mdx: theenvironmentsecrets provider (TOOLHIVE_SECRET_*, read-only, for CI/CD) added to the provider catalog and tabs, plus the non-interactivethv secret providercommand.All flags and commands were verified against the auto-generated CLI reference and ToolHive source.
Type of change
Related issues/PRs
Addresses #654 (medium-priority gaps). The two registry items (
set-registryOIDC and--allow-private-ip) are covered in #934, and the build customization flags (--runtime-image/--runtime-add-package) in #933. The remainingrun-mcp-serversadditions deliberately avoid restructuring ahead of the page split tracked in #937.