Open
Conversation
This commit contains fixes for a number of errors incorrectly thrown when validating person records
I previously thought that all attribute classes were imported into the compiled ODD from the tei:module key="tei". I didn't understand why I had to go back and add att.global.analytic to get the @ana attribute to become available. I just figured out that the att.global.analytic attribute class is added by using tei:module key="analysis". It works even with all of the elements excluded.
This data has been moved into the work record srophe/syriaca-data#1192 srophe/syriaca-data#1204
Update against the new index of persons and places in the srophe branch instead of the old index in the srophe-exist-app branch
Contributor
|
@dlschwartz Can you make this pull request on Gaddel instead? https://github.com/srophe/Gaddel |
Contributor
Author
|
@wsalesky I don't actually know how to make a pull request across repos. But, it looks like these files are only a couple of months out of date on Gaddel. My inclination is just to update the schema files on the main branch of Gaddel manually. Does that sound alright to you? |
Contributor
|
Yes, go ahead
…On Mon, May 5, 2025 at 11:08 AM Daniel Schwartz ***@***.***> wrote:
*dlschwartz* left a comment (srophe/syriaca#262)
<#262 (comment)>
@wsalesky <https://github.com/wsalesky> I don't actually know how to make
a pull request across repos. But, it looks like these files are only a
couple of months out of date on Gaddel. My inclination is just to update
the schema files on the main branch of Gaddel manually. Does that sound
alright to you?
—
Reply to this email directly, view it on GitHub
<#262 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI5GTQNL2USURSEPC6KLNL2455FDAVCNFSM6AAAAAB4O2HWVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNJRGMYTGMJVGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wsalesky I would like to merge the schema from this branch to main. I assumed there would be a conflict and there is. Can I ask you to look into this? I thought about manually merging the files in the syriaca/documentation/schemas folder but I think it might be best if you take a look. Thanks Winona.