Export Sqids from sqids module

[Popkornium18]

The previous code did not export the Sqids class leading to private import usage warnings when using from sqids import Sqids. One could work around it by using from sqids.sqids import Sqids. This workaround is now no longer necessary.

[Pevtrick]

Hey thanks for the PR, i wasn't aware that this could result in a warning. I'd like to read more about it, would you mind providing resources related to the warning? Does __all__ = ['Sqids'] fix your problem as well? If so, i think it is a better solution as one won't oversee it in case of additional package level "exports" in the future.

[Popkornium18]

You can reproduce the issue like this. This is file.py

from sqids import Sqids
_ = Sqids()

Then run:

$ mypy --strict file.py
file.py:1: error: Module "sqids" does not explicitly export attribute "Sqids"  [attr-defined]
$ pyright file.py
/home/user/file.py
  /home/user/file.py:1:19 - error: "Sqids" is not exported from module "sqids"
    Import from "sqids.sqids" instead (reportPrivateImportUsage)
1 error, 0 warnings, 0 informations

__all__ = ["Sqids"] does also solve the issue. I just prefer the from sqids import Sqids as Sqids way, since it looks better in a file with tons of exports and it is simpler to append another export and keep them sorted with reorder-python-imports/isort. But __all__ = ["Sqids"] is probably more common. Something about that String notation just rubs me the wrong way.

But I can change it to __all__ if you prefer.

[Pevtrick]

Okay i see it is a mypy warning... that is why i didn't see it in my test setup. Yes please change it to the __all__ notation. Thx for clarification. 😊

[Popkornium18]

done

[Pevtrick]

I will take a look at this tomorrow... 😅

[jules-ch]

Possible to release a new version to correct this ? :)

[4kimov]

Done.