Open
Conversation
64bb8fc to
b605ace
Compare
- Move default blocklist to its own file so `class Sqids` is visible upon opening - Export `minAlphabetLength`, `minLengthLimit`, and `maxValue` so they're available to downstream consumers - Enforce `Required<SqidsOptions>` type on defaultOptions
b605ace to
cf29866
Compare
Member
|
@robhanlon22 Thanks for the PR. Two questions for you:
|
Author
Sure, I can do that. I was following the convention of
Sure, I'll try it out, and see if anything needs tweaking. |
Member
|
@robhanlon22 Cool, thank you. Regarding naming convention, I always thought this approach was reasonable for JS: https://stackoverflow.com/a/49537197 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
class Sqidsis visible upon openingminAlphabetLength,minLengthLimit, andmaxValueso they're available to downstream consumersRequired<SqidsOptions>type on defaultOptions