Wire SessionMemoryAdvisor to resolve and use CompactionScope - #38
Open
AdepuSriCharan wants to merge 3 commits into
Open
Wire SessionMemoryAdvisor to resolve and use CompactionScope#38AdepuSriCharan wants to merge 3 commits into
AdepuSriCharan wants to merge 3 commits into
Conversation
- add session and branch compaction scopes - make compaction strategies use scope-aware turn boundaries - preserve existing session-level compaction behavior - add tests for session and branch scope semantics Signed-off-by: Adepu Sri Charan <sricharan.adepu36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #37 (please review that first).
This is the final piece for branch-aware compaction. With
CompactionScopeintroduced in #36 and wired through the repository layer in #37, this PR makesSessionMemoryAdvisoruse it at runtime.Changes
SessionMemoryAdvisorresolves its activeEventFilterand passes it toSessionService, ensuring compaction only targets the active branch.SessionMemoryAdvisorITto reproduce the original compaction starvation issue and verify branch-local compaction triggers and archives correctly.Fixes #35.