mcp-server: return 401 when API key is missing - #90
Open
arnabnandy7 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46.
Problem
When an API-key-protected MCP endpoint receives a request without an API key, the API key authentication filter passes the request through so another configured authentication mechanism can authenticate it.
If no mechanism authenticates the request, Spring Security currently uses its default entry point and returns
403 Forbidden. Since the request is unauthenticated, it should instead return401 Unauthorized.An unconditional API key entry point is not sufficient because it overrides the OAuth2 resource server entry point when API key and OAuth2 authentication are configured together. This prevents the OAuth2
WWW-Authenticatechallenge from being returned.Changes
401 Unauthorizedentry point for API-key authentication when MCP OAuth2 security is not configured.401 Unauthorized.WWW-Authenticateheader.Result
401 Unauthorized401 Unauthorizedwith the OAuth2WWW-Authenticatechallenge401 Unauthorized403 Forbiddenbehavior is unchangedTesting