feat(home): make upstream proof-band logos clickable (expand PRs in place)#16
Merged
Conversation
…lace) The 12 brand logos on the home page looked clickable but weren't. Each is now a button that expands that repo's merged-PR card in place — right on the home page, no navigation and no scroll, so the visitor stays exactly where they were. Mirrors the /upstream tile's expand. - New components/upstream/pr-list.tsx: the merged-PR <ul> lifted out of brand-tile.tsx so the /upstream tiles and the home panel share one source of truth for PR-row styling. - New components/home/upstream-proof-marquee.tsx (client): logos become buttons (aria-expanded/-controls, hover + focus-visible + active accent highlight); a single panel below the grid expands the open repo's PRs using the same grid-rows accordion + requestLenisResize as BrandTile. displayedSlug lags openSlug so content stays mounted through the close. - upstream-proof-band.tsx (server) now computes prsForRepo + prsCount labels per brand and feeds the client marquee; counts/marquee unchanged. typecheck + lint + build clean; 12 clickable buttons render with the shared panel; /upstream tiles unaffected (pure extraction). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The 12 brand logos in the home
/upstreamproof band looked clickable but weren't. Each is now a button; clicking it expands that repo's merged-PR card in place — right on the home page, no navigation and no scroll, so the visitor stays exactly where they were. Click again to collapse; clicking another swaps. Mirrors the/upstreamtile's expand.Per the user's steer: no scroll-to-/upstream (jarring) — the card unfolds where you are.
How
components/upstream/pr-list.tsx— the merged-PR<ul>lifted out ofbrand-tile.tsxso the/upstreamtiles and the home panel share one source of truth for PR-row styling.components/home/upstream-proof-marquee.tsx(client) — logos become<button>s (aria-expanded/aria-controls, hover +focus-visiblering + active accent highlight); a single panel below the grid expands the open repo's PRs using the samegrid-rowsaccordion +requestLenisResizeasBrandTile.displayedSluglagsopenSlugso content stays mounted through the collapse.upstream-proof-band.tsx(server) computesprsForRepo+ theprsCountlabel per brand and feeds the client marquee. Counts, marquee slugs, eyebrow/heading/sub/CTA unchanged.Verification
pnpm typecheck+pnpm lint+pnpm buildclean (168 pages). Server HTML confirms 12<button aria-expanded="false" aria-controls="upstream-proof-panel">logos + the panel region + all 12 labels; no hydration errors./upstreamtiles unaffected (the PR-list change is a pure extraction, reusing the exact markup). Interaction reuses the accordion pattern already proven in production on/upstream.🤖 Generated with Claude Code