Complete deprecation of legacy shell implementation#2355
Conversation
- Remove legacy `/shell` page frontend components - Rename `shellv2` page to `shell` and update all client-side navigation paths - Remove legacy WebSocket stream server endpoints (`stream.NewShellHandler`, `stream.NewPingHandler`) from `app.go` - Route `/shell/ws` to use the refactored `tavernshell.NewHandler` (previously `shellv2`) - Refactor `tavern/config.go` `NewShellMuxes` into `NewGRPCShellMux` that only initializes the required C2 `grpcMux` instance, effectively deleting the `wsMux` that was bound to the legacy shell components. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change fully completes the deprecation of the v1 shell implementation across both the frontend React application and the Go backend service. It re-aligns the
shellv2nomenclature directly to theshellpath logic seamlessly while pruning all unneeded code (e.g.,wsMux,websocket.go).PR created automatically by Jules for task 18154692210956958747 started by @KCarretto