Refine benchmark cost and time accounting - #91
Merged
Conversation
Qian-Cheng-nju
marked this pull request as ready for review
July 30, 2026 14:28
Qian-Cheng-nju
marked this pull request as draft
July 30, 2026 14:29
Qian-Cheng-nju
marked this pull request as ready for review
July 30, 2026 16:35
munimthahmid
approved these changes
Jul 30, 2026
munimthahmid
left a comment
Contributor
There was a problem hiding this comment.
@Qian-Cheng-nju Reviewed the implementation thoroughly. Also I ran Codex, Claude Code, and one shot OpenAI calls on a small proof, including complete and timeout paths . Wall time, token/request accounting, fail-closed behavior, and headline equivalent costs were reported correctly.
I found no major issue. Approving.
Member
Author
|
Thanks a lot! @munimthahmid Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary