Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 15, 2026

Signed-off-by: Juan Cruz Viotti [email protected]

@augmentcode
Copy link

augmentcode bot commented Jan 15, 2026

🤖 Augment PR Summary

Summary: Updates the vendored sourcemeta/core dependency to a newer upstream commit and aligns the local vendored sources with upstream behavior.

Changes:

  • Bumped core in DEPENDENCIES to 6866e0e65979ced65cb5d37bde8cffd26eae9b86.
  • Refactored JSON Schema framing utilities in vendor/core/src/core/jsonschema/frame.cc to be container-agnostic (now templated over map type).
  • Introduced a combined walk (CombinedWalkResult / find_dialect_and_all_bases) to gather nearest dialect + all base URIs in a single traversal.
  • Switched internal caches for subschemas/base URIs/dialects from std::unordered_map to std::map.
  • Updated the pointer-location framing loop to reuse precomputed “nearest base” information and hoist base view/dialect lookups.

Technical Notes: The framing pass now derives the dialect match and base-URI chain together, reducing repeated ancestor walks and keeping base-depth/dialect metadata consistent across stored locations.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit ff98946 into main Jan 15, 2026
4 checks passed
@jviotti jviotti deleted the core-fast branch January 15, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants