Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 16, 2026

Signed-off-by: Juan Cruz Viotti [email protected]

@augmentcode
Copy link

augmentcode bot commented Jan 16, 2026

🤖 Augment PR Summary

Summary: This PR removes the JSON Pointer “mangling” API that converted a pointer + prefix into a collision-free identifier.

Changes:

  • Dropped the public declaration and documentation for sourcemeta::core::mangle from jsonpointer.h
  • Removed the implementation file src/core/jsonpointer/mangle.cc from the jsonpointer library build
  • Removed the dedicated unit test suite for mangling (jsonpointer_mangle_test.cc) and its CMake entry

Technical Notes: This is a public API removal from the sourcemeta::core::jsonpointer component; internal repo references appear to be gone alongside the function and tests.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit 53dced3 into main Jan 16, 2026
13 checks passed
@jviotti jviotti deleted the no-pointer-mangle branch January 16, 2026 17:49
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: 43b7c25 Previous: c0180e5 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 3.152075476516086 ns/iter 3.111673150301063 ns/iter 1.01
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.1075856152581944 ns/iter 3.1138941747901185 ns/iter 1.00
Regex_Period_Asterisk 3.1076359084418086 ns/iter 3.106416522321149 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 3.1081807316295804 ns/iter 3.1072366682583046 ns/iter 1.00
Regex_Period_Plus 2.995066259595626 ns/iter 2.815908175538773 ns/iter 1.06
Regex_Period 3.105465485380168 ns/iter 3.1118328233555403 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 2.968469004730979 ns/iter 3.1081268609471127 ns/iter 0.96
Regex_Caret_Group_Period_Plus_Group_Dollar 2.9774665181679487 ns/iter 3.106843082740002 ns/iter 0.96
Regex_Caret_Period_Asterisk_Dollar 3.108604148498102 ns/iter 3.1063862538730573 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.203884865691965 ns/iter 3.107498538510128 ns/iter 1.03
Regex_Caret_X_Hyphen 10.2594333743991 ns/iter 7.458983452893287 ns/iter 1.38
Regex_Period_Md_Dollar 27.51557005802596 ns/iter 27.582131016974326 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 6.217420069817627 ns/iter 7.150639202402882 ns/iter 0.87
Regex_Caret_Period_Range_Dollar 3.7304706879536913 ns/iter 3.7294689386800606 ns/iter 1.00
Regex_Nested_Backtrack 49.80552247334591 ns/iter 49.64028503689433 ns/iter 1.00
JSON_Array_Of_Objects_Unique 419.4108934325056 ns/iter 429.5375000596932 ns/iter 0.98
JSON_Parse_1 29383.319410010412 ns/iter 29232.070755307468 ns/iter 1.01
JSON_Parse_Real 38466.679277398965 ns/iter 38885.01864341336 ns/iter 0.99
JSON_Parse_Decimal 129605.36117799811 ns/iter 130322.30813629557 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 62.51948325604838 ns/iter 62.48970067039851 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 167.5402819015505 ns/iter 167.5960547868465 ns/iter 1.00
JSON_String_Equal/10 7.1583067900207995 ns/iter 7.948781113572173 ns/iter 0.90
JSON_String_Equal/100 7.782686605244986 ns/iter 7.161354928123989 ns/iter 1.09
JSON_String_Equal_Small_By_Perfect_Hash/10 0.9382342175174181 ns/iter 0.9380565604372566 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 10.261095604036122 ns/iter 10.259950294656997 ns/iter 1.00
JSON_String_Fast_Hash/10 2.4870158959892548 ns/iter 2.4875078218966227 ns/iter 1.00
JSON_String_Fast_Hash/100 2.4871836818869997 ns/iter 2.486704473746119 ns/iter 1.00
JSON_String_Key_Hash/10 2.491281983967138 ns/iter 2.490282885003049 ns/iter 1.00
JSON_String_Key_Hash/100 6.528488410513556 ns/iter 6.528382478388408 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 3.735285910917357 ns/iter 3.7353668513463107 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 3.737270422873918 ns/iter 3.733821003112953 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.733986374191302 ns/iter 3.7455896002422895 ns/iter 1.00
Pointer_Object_Traverse 46.113608340057674 ns/iter 46.072844480154565 ns/iter 1.00
Pointer_Object_Try_Traverse 53.85238239479184 ns/iter 53.840817270802354 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 337.2089999080181 ns/iter 327.76649901716866 ns/iter 1.03
Pointer_Walker_Schema_ISO_Language 3172173.6486483803 ns/iter 3174624.153846057 ns/iter 1.00
Schema_Frame_WoT_References 5751939.483333975 ns/iter 5709063.691056588 ns/iter 1.01
Schema_Frame_OMC_References 28130291.499997802 ns/iter 26609394.423076086 ns/iter 1.06
Schema_Frame_OMC_Locations 26092546.481482647 ns/iter 25198074.035716087 ns/iter 1.04
Schema_Frame_ISO_Language_Locations 124575701.00000338 ns/iter 123069757.40000327 ns/iter 1.01
Schema_Iterator_ISO_Language 2345558.573825433 ns/iter 2343853.094276153 ns/iter 1.00
Schema_Frame_ISO_Language_Locations_To_JSON 129525614.00001627 ns/iter 131513812.99999799 ns/iter 0.98
Schema_Tracker_ISO_Language 47964926.499998584 ns/iter 48376859.466664724 ns/iter 0.99
Schema_Tracker_ISO_Language_To_JSON 24871576.99999898 ns/iter 23485420.766667176 ns/iter 1.06
Schema_Format_ISO_Language_To_JSON 132257263.00004224 ns/iter 130797463.99998839 ns/iter 1.01
Schema_Bundle_Meta_2020_12 2146818.266871247 ns/iter 2138648.3853211203 ns/iter 1.00
Schema_Frame_Many_Resources_References 261400023.3333324 ns/iter 253518055.00001016 ns/iter 1.03
Alterschema_Check_Readibility_ISO_Language_Set_3 232661218.33334336 ns/iter 228502710.99999496 ns/iter 1.02
Alterschema_Check_Readibility_OMC 33300409.399998896 ns/iter 31983659.36363375 ns/iter 1.04
EditorSchema_ForEditor_EmbeddedResources 14312318.979577588 ns/iter 13977567.799997814 ns/iter 1.02
URITemplateRouter_Create 17208.324681897524 ns/iter 17103.26912001696 ns/iter 1.01
URITemplateRouter_Match 173.3310255871646 ns/iter 175.4755565405977 ns/iter 0.99
URITemplateRouterView_Restore 8231.104986700933 ns/iter 8085.602731102 ns/iter 1.02
URITemplateRouterView_Match 135.74136657215055 ns/iter 136.96816118190202 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Details
Benchmark suite Current: 43b7c25 Previous: c0180e5 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 3.5428776785713416 ns/iter 3.8056451717758915 ns/iter 0.93
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.325208482143032 ns/iter 3.7777751718248886 ns/iter 0.88
Regex_Period_Asterisk 3.4459842241343703 ns/iter 4.397059831244057 ns/iter 0.78
Regex_Group_Period_Asterisk_Group 3.055435714285539 ns/iter 4.09204466335135 ns/iter 0.75
Regex_Period_Plus 3.048187498639512 ns/iter 4.4086793749997355 ns/iter 0.69
Regex_Period 3.029019642856972 ns/iter 4.401269374999828 ns/iter 0.69
Regex_Caret_Period_Plus_Dollar 2.6964185690208455 ns/iter 4.083456703720595 ns/iter 0.66
Regex_Caret_Group_Period_Plus_Group_Dollar 2.6620770511943572 ns/iter 3.8195426717503365 ns/iter 0.70
Regex_Caret_Period_Asterisk_Dollar 3.075252678571465 ns/iter 4.102173801968355 ns/iter 0.75
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.9090921166395574 ns/iter 3.79939823067042 ns/iter 0.77
Regex_Caret_X_Hyphen 6.212897321429267 ns/iter 7.541088169642813 ns/iter 0.82
Regex_Period_Md_Dollar 30.715272321429104 ns/iter 35.21275333563067 ns/iter 0.87
Regex_Caret_Slash_Period_Asterisk 5.847289999999248 ns/iter 7.218014508928609 ns/iter 0.81
Regex_Caret_Period_Range_Dollar 3.214870786273014 ns/iter 4.090745409091023 ns/iter 0.79
Regex_Nested_Backtrack 91.17937500000245 ns/iter 98.63380809670755 ns/iter 0.92
JSON_Array_Of_Objects_Unique 412.75417629386664 ns/iter 498.82479999996576 ns/iter 0.83
JSON_Parse_1 76356.58482141951 ns/iter 72624.02678571382 ns/iter 1.05
JSON_Parse_Real 97414.93303570944 ns/iter 92601.92848533986 ns/iter 1.05
JSON_Parse_Decimal 338230.09845287015 ns/iter 349314.8357289718 ns/iter 0.97
JSON_Fast_Hash_Helm_Chart_Lock 50.38107701743054 ns/iter 71.39603571428462 ns/iter 0.71
JSON_Equality_Helm_Chart_Lock 285.9078890219666 ns/iter 273.84266634630166 ns/iter 1.04
JSON_String_Equal/10 10.854534375001279 ns/iter 12.429385658797731 ns/iter 0.87
JSON_String_Equal/100 13.490051785715146 ns/iter 13.888564893354573 ns/iter 0.97
JSON_String_Equal_Small_By_Perfect_Hash/10 1.8100506453010805 ns/iter 2.1994618749999972 ns/iter 0.82
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 9.13014638781126 ns/iter 12.900587499999006 ns/iter 0.71
JSON_String_Fast_Hash/10 2.6513116494182567 ns/iter 4.958504115997687 ns/iter 0.53
JSON_String_Fast_Hash/100 2.771086894847512 ns/iter 4.257891875000297 ns/iter 0.65
JSON_String_Key_Hash/10 2.6618068726236794 ns/iter 4.216068681153527 ns/iter 0.63
JSON_String_Key_Hash/100 14.630560648970777 ns/iter 13.964886098371748 ns/iter 1.05
JSON_Object_Defines_Miss_Same_Length 5.0299651785711115 ns/iter 4.734833715925909 ns/iter 1.06
JSON_Object_Defines_Miss_Too_Small 4.299714440045288 ns/iter 3.8567131696431995 ns/iter 1.11
JSON_Object_Defines_Miss_Too_Large 5.028088999999909 ns/iter 4.789994642857819 ns/iter 1.05
Pointer_Object_Traverse 46.7906461337234 ns/iter 51.223857142852175 ns/iter 0.91
Pointer_Object_Try_Traverse 64.34682142859012 ns/iter 74.75606249999244 ns/iter 0.86
Pointer_Push_Back_Pointer_To_Weak_Pointer 179.6092151524018 ns/iter 152.56716517857427 ns/iter 1.18
Pointer_Walker_Schema_ISO_Language 12986676.78571519 ns/iter 9679792.00000021 ns/iter 1.34
Schema_Frame_WoT_References 11740821.875001473 ns/iter 10912204.687500093 ns/iter 1.08
Schema_Frame_OMC_References 56785354.54545785 ns/iter 56165699.999996826 ns/iter 1.01
Schema_Frame_OMC_Locations 51728772.7272808 ns/iter 52909729.99999894 ns/iter 0.98
Schema_Frame_ISO_Language_Locations 233993766.66664767 ns/iter 246265900.00002578 ns/iter 0.95
Schema_Iterator_ISO_Language 4970223.489933397 ns/iter 4497720.6896544825 ns/iter 1.11
Schema_Frame_ISO_Language_Locations_To_JSON 249005633.33327833 ns/iter 256278899.99998388 ns/iter 0.97
Schema_Tracker_ISO_Language 107479699.99999894 ns/iter 104699099.99998587 ns/iter 1.03
Schema_Tracker_ISO_Language_To_JSON 55915589.99999507 ns/iter 56247109.090908125 ns/iter 0.99
Schema_Format_ISO_Language_To_JSON 237869200.00005314 ns/iter 240216700.00001904 ns/iter 0.99
Schema_Bundle_Meta_2020_12 4195920.12986254 ns/iter 4168518.750000061 ns/iter 1.01
Schema_Frame_Many_Resources_References 473377799.9999802 ns/iter 503703200.0000181 ns/iter 0.94
Alterschema_Check_Readibility_ISO_Language_Set_3 342361999.9999801 ns/iter 362762550.0000136 ns/iter 0.94
Alterschema_Check_Readibility_OMC 64195109.090901904 ns/iter 65034954.5454467 ns/iter 0.99
EditorSchema_ForEditor_EmbeddedResources 25758050.000000857 ns/iter 25312203.333335977 ns/iter 1.02
URITemplateRouter_Create 21577.084374996502 ns/iter 23068.681153111975 ns/iter 0.94
URITemplateRouter_Match 229.676928571426 ns/iter 209.49214689768877 ns/iter 1.10
URITemplateRouterView_Restore 25929.7535714284 ns/iter 33265.551024234774 ns/iter 0.78
URITemplateRouterView_Match 157.41562500001092 ns/iter 146.47881042505952 ns/iter 1.07

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: 43b7c25 Previous: c0180e5 Ratio
URITemplateRouter_Create 14087.73488790723 ns/iter 14008.732731359278 ns/iter 1.01
URITemplateRouter_Match 178.54322579458332 ns/iter 181.37075167058396 ns/iter 0.98
URITemplateRouterView_Restore 8249.329785689133 ns/iter 8366.54766792657 ns/iter 0.99
URITemplateRouterView_Match 113.46347209226117 ns/iter 115.34129993584119 ns/iter 0.98
EditorSchema_ForEditor_EmbeddedResources 15139688.93479871 ns/iter 15127853.217390822 ns/iter 1.00
Alterschema_Check_Readibility_ISO_Language_Set_3 236029900.3333542 ns/iter 233906123.66665664 ns/iter 1.01
Alterschema_Check_Readibility_OMC 36983259.78947842 ns/iter 36111399.100002475 ns/iter 1.02
Schema_Frame_WoT_References 6416370.3577979095 ns/iter 6329868.645455214 ns/iter 1.01
Schema_Frame_OMC_References 30622652.17391027 ns/iter 30052844.291664843 ns/iter 1.02
Schema_Frame_OMC_Locations 28896400.12499702 ns/iter 29181863.59999709 ns/iter 0.99
Schema_Frame_ISO_Language_Locations 129162668.19997874 ns/iter 128516256.40000749 ns/iter 1.01
Schema_Iterator_ISO_Language 2568019.579335481 ns/iter 2796202.13492066 ns/iter 0.92
Schema_Frame_ISO_Language_Locations_To_JSON 297260804.50006974 ns/iter 302343172.00006443 ns/iter 0.98
Schema_Tracker_ISO_Language 51401889.99999802 ns/iter 51760507.53846959 ns/iter 0.99
Schema_Tracker_ISO_Language_To_JSON 37002083.684204705 ns/iter 35026697.36842204 ns/iter 1.06
Schema_Format_ISO_Language_To_JSON 140073759.80004328 ns/iter 136430184.80001956 ns/iter 1.03
Schema_Bundle_Meta_2020_12 2379968.88136661 ns/iter 2424183.084750146 ns/iter 0.98
Schema_Frame_Many_Resources_References 278903761.5000325 ns/iter 277289954.50002 ns/iter 1.01
Pointer_Object_Traverse 46.18931034796536 ns/iter 46.06600609068735 ns/iter 1.00
Pointer_Object_Try_Traverse 22.740489111562187 ns/iter 22.74506854408817 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 167.97184929424435 ns/iter 224.2002898438968 ns/iter 0.75
Pointer_Walker_Schema_ISO_Language 3515864.583755848 ns/iter 3213648.303922217 ns/iter 1.09
JSON_Array_Of_Objects_Unique 428.43812906249406 ns/iter 420.04785395784546 ns/iter 1.02
JSON_Parse_1 33173.076360032544 ns/iter 33469.43499764594 ns/iter 0.99
JSON_Parse_Real 43883.173603676005 ns/iter 44632.58745622484 ns/iter 0.98
JSON_Parse_Decimal 157275.29847741956 ns/iter 156549.93528232593 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 62.25451795505824 ns/iter 59.82359357290687 ns/iter 1.04
JSON_Equality_Helm_Chart_Lock 153.65209540464218 ns/iter 155.68886309504887 ns/iter 0.99
JSON_String_Equal/10 6.652020225435196 ns/iter 6.65814132369703 ns/iter 1.00
JSON_String_Equal/100 7.277694299977677 ns/iter 7.308950694023083 ns/iter 1.00
JSON_String_Equal_Small_By_Perfect_Hash/10 0.6260652363290827 ns/iter 0.625779927438219 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 19.58419051502104 ns/iter 19.58372549001728 ns/iter 1.00
JSON_String_Fast_Hash/10 2.3482682800369257 ns/iter 2.3163444762453516 ns/iter 1.01
JSON_String_Fast_Hash/100 2.3467751574351 ns/iter 2.3131919625727906 ns/iter 1.01
JSON_String_Key_Hash/10 1.247077655587271 ns/iter 1.246459570491517 ns/iter 1.00
JSON_String_Key_Hash/100 12.428363193300306 ns/iter 12.427060515761113 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 2.487803599848074 ns/iter 2.5105291512472627 ns/iter 0.99
JSON_Object_Defines_Miss_Too_Small 2.800347606533485 ns/iter 2.8006620027103253 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 2.7982741147628363 ns/iter 2.799847350866205 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 3.118649213305752 ns/iter 3.111001900164949 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.120211826722192 ns/iter 3.123610297573724 ns/iter 1.00
Regex_Period_Asterisk 3.109893647411967 ns/iter 3.111466346196761 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 3.109014074031154 ns/iter 3.1185119151186815 ns/iter 1.00
Regex_Period_Plus 2.7997580579726993 ns/iter 2.7994741654286233 ns/iter 1.00
Regex_Period 2.799395083005245 ns/iter 2.7989490017133045 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 2.7978900184962225 ns/iter 2.799550276780108 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 2.799955679351066 ns/iter 2.8093448736801725 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 3.49004034599501 ns/iter 3.111437257978841 ns/iter 1.12
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.1090910205156947 ns/iter 3.1198366189227964 ns/iter 1.00
Regex_Caret_X_Hyphen 13.060546223279122 ns/iter 13.6825870536637 ns/iter 0.95
Regex_Period_Md_Dollar 44.01275059005397 ns/iter 36.17074098564059 ns/iter 1.22
Regex_Caret_Slash_Period_Asterisk 7.802000409262097 ns/iter 8.70493999994639 ns/iter 0.90
Regex_Caret_Period_Range_Dollar 4.053820135646617 ns/iter 4.040720309091319 ns/iter 1.00
Regex_Nested_Backtrack 65.72939611497722 ns/iter 60.113499154726505 ns/iter 1.09

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: 43b7c25 Previous: c0180e5 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.492935986967163 ns/iter 1.9086898603294982 ns/iter 1.31
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.3207290646775722 ns/iter 1.7399509536498192 ns/iter 1.33
Regex_Period_Asterisk 2.61954045560855 ns/iter 1.9828194655549505 ns/iter 1.32
Regex_Group_Period_Asterisk_Group 2.167041568349118 ns/iter 2.225410379707914 ns/iter 0.97
Regex_Period_Plus 3.0428281544753095 ns/iter 2.566797617142623 ns/iter 1.19
Regex_Period 3.3521880566919573 ns/iter 2.6299716437194935 ns/iter 1.27
Regex_Caret_Period_Plus_Dollar 2.8330725702493944 ns/iter 2.276679509339513 ns/iter 1.24
Regex_Caret_Group_Period_Plus_Group_Dollar 3.360124201955831 ns/iter 2.2356288783028515 ns/iter 1.50
Regex_Caret_Period_Asterisk_Dollar 2.708973424172284 ns/iter 2.082345329364322 ns/iter 1.30
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.4222168151850436 ns/iter 1.9328395500753246 ns/iter 1.25
Regex_Caret_X_Hyphen 9.455935852986977 ns/iter 6.946481712697425 ns/iter 1.36
Regex_Period_Md_Dollar 31.870442980281048 ns/iter 23.74112871435692 ns/iter 1.34
Regex_Caret_Slash_Period_Asterisk 8.754187207268366 ns/iter 6.837539211727703 ns/iter 1.28
Regex_Caret_Period_Range_Dollar 2.8084057785593903 ns/iter 2.397735786591644 ns/iter 1.17
Regex_Nested_Backtrack 47.18403852681357 ns/iter 33.73470143425232 ns/iter 1.40
JSON_Array_Of_Objects_Unique 500.3893988020088 ns/iter 415.6419578802614 ns/iter 1.20
JSON_Parse_1 29320.832521193053 ns/iter 27194.79368787429 ns/iter 1.08
JSON_Parse_Real 35179.6580417402 ns/iter 33661.583369824795 ns/iter 1.05
JSON_Parse_Decimal 329481.0377171188 ns/iter 359160.99391039496 ns/iter 0.92
JSON_Fast_Hash_Helm_Chart_Lock 69.39854090968431 ns/iter 87.3816317288218 ns/iter 0.79
JSON_Equality_Helm_Chart_Lock 168.68405487243953 ns/iter 194.80159315328018 ns/iter 0.87
JSON_String_Equal/10 8.742715942673168 ns/iter 9.073636902704173 ns/iter 0.96
JSON_String_Equal/100 8.519749276472389 ns/iter 9.28089382407844 ns/iter 0.92
JSON_String_Equal_Small_By_Perfect_Hash/10 0.3819224743200482 ns/iter 0.4583784203798372 ns/iter 0.83
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 4.916591241052596 ns/iter 4.244337628814249 ns/iter 1.16
JSON_String_Fast_Hash/10 2.5839929802555366 ns/iter 3.3449753888532356 ns/iter 0.77
JSON_String_Fast_Hash/100 2.6512980771850665 ns/iter 2.4724658115044598 ns/iter 1.07
JSON_String_Key_Hash/10 1.5532715894115914 ns/iter 1.6542257186984828 ns/iter 0.94
JSON_String_Key_Hash/100 2.6222585910612097 ns/iter 2.3984765829911736 ns/iter 1.09
JSON_Object_Defines_Miss_Same_Length 3.8327293078018787 ns/iter 3.0804241858441537 ns/iter 1.24
JSON_Object_Defines_Miss_Too_Small 3.2467627031497766 ns/iter 3.2009598502955035 ns/iter 1.01
JSON_Object_Defines_Miss_Too_Large 3.251782783209667 ns/iter 3.3161696368787865 ns/iter 0.98
Pointer_Object_Traverse 19.51221646631128 ns/iter 16.943689114626572 ns/iter 1.15
Pointer_Object_Try_Traverse 31.154465253531956 ns/iter 24.000566073138096 ns/iter 1.30
Pointer_Push_Back_Pointer_To_Weak_Pointer 237.38884529089765 ns/iter 177.96365996121824 ns/iter 1.33
Pointer_Walker_Schema_ISO_Language 5566496.49473624 ns/iter 7103539.682540421 ns/iter 0.78
Schema_Frame_WoT_References 7732812.97727315 ns/iter 8730042.17072964 ns/iter 0.89
Schema_Frame_OMC_References 43808284.352949426 ns/iter 45604859.37500402 ns/iter 0.96
Schema_Frame_OMC_Locations 35815865.777774684 ns/iter 45493281.25000329 ns/iter 0.79
Schema_Frame_ISO_Language_Locations 114703076.49998783 ns/iter 149246541.5999959 ns/iter 0.77
Schema_Iterator_ISO_Language 2289518.714754001 ns/iter 3076409.46261693 ns/iter 0.74
Schema_Frame_ISO_Language_Locations_To_JSON 129685975.00002941 ns/iter 139778541.74999037 ns/iter 0.93
Schema_Tracker_ISO_Language 56892333.400014654 ns/iter 65275670.454556435 ns/iter 0.87
Schema_Tracker_ISO_Language_To_JSON 19476529.175000224 ns/iter 17730636.029408313 ns/iter 1.10
Schema_Format_ISO_Language_To_JSON 114864492.83332454 ns/iter 129121399.99993996 ns/iter 0.89
Schema_Bundle_Meta_2020_12 1769721.0953797025 ns/iter 1973654.7242180728 ns/iter 0.90
Schema_Frame_Many_Resources_References 346197978.9999532 ns/iter 277381860.99994284 ns/iter 1.25
Alterschema_Check_Readibility_ISO_Language_Set_3 248787239.7500155 ns/iter 273888406.2500233 ns/iter 0.91
Alterschema_Check_Readibility_OMC 46664807.69230055 ns/iter 48604719.72727448 ns/iter 0.96
EditorSchema_ForEditor_EmbeddedResources 18719023.880959995 ns/iter 16685021.414637383 ns/iter 1.12
URITemplateRouter_Create 22373.958185406533 ns/iter 20508.135642319423 ns/iter 1.09
URITemplateRouter_Match 227.57172283671454 ns/iter 216.95443175089883 ns/iter 1.05
URITemplateRouterView_Restore 14766.122202962062 ns/iter 17532.243908554607 ns/iter 0.84
URITemplateRouterView_Match 145.83183529020346 ns/iter 158.4442827945241 ns/iter 0.92

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/gcc)

Details
Benchmark suite Current: 43b7c25 Previous: c0180e5 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.356060173173386 ns/iter 3.1023224206899807 ns/iter 0.76
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.341643953223101 ns/iter 3.829944350869751 ns/iter 0.61
Regex_Period_Asterisk 2.416954461864417 ns/iter 3.5662692878330553 ns/iter 0.68
Regex_Group_Period_Asterisk_Group 2.4533451876937415 ns/iter 3.0455221311444634 ns/iter 0.81
Regex_Period_Plus 2.582177198198607 ns/iter 3.156950276452636 ns/iter 0.82
Regex_Period 2.482959735536258 ns/iter 2.882356004741387 ns/iter 0.86
Regex_Caret_Period_Plus_Dollar 2.4657400854515177 ns/iter 2.933809406299539 ns/iter 0.84
Regex_Caret_Group_Period_Plus_Group_Dollar 2.481945231535346 ns/iter 3.238501615571195 ns/iter 0.77
Regex_Caret_Period_Asterisk_Dollar 2.2904297186003837 ns/iter 2.8852146008658663 ns/iter 0.79
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.233110623556587 ns/iter 2.5758053747896668 ns/iter 0.87
Regex_Caret_X_Hyphen 6.932523137975596 ns/iter 8.668939366554847 ns/iter 0.80
Regex_Period_Md_Dollar 26.28688576836453 ns/iter 35.54340891473797 ns/iter 0.74
Regex_Caret_Slash_Period_Asterisk 6.291171652630602 ns/iter 6.401205755510161 ns/iter 0.98
Regex_Caret_Period_Range_Dollar 3.4623100872845236 ns/iter 2.754123552725143 ns/iter 1.26
Regex_Nested_Backtrack 70.79231755976342 ns/iter 58.87681303296193 ns/iter 1.20
JSON_Array_Of_Objects_Unique 393.418052867516 ns/iter 349.2618669552138 ns/iter 1.13
JSON_Parse_1 35582.54565643667 ns/iter 34897.98345355549 ns/iter 1.02
JSON_Parse_Real 36673.29420829511 ns/iter 34755.38913374692 ns/iter 1.06
JSON_Parse_Decimal 423189.76471687586 ns/iter 346388.11560238106 ns/iter 1.22
JSON_Fast_Hash_Helm_Chart_Lock 46.51019645161766 ns/iter 41.16006191343581 ns/iter 1.13
JSON_Equality_Helm_Chart_Lock 140.7898803631202 ns/iter 170.8003819629373 ns/iter 0.82
JSON_String_Equal/10 6.420597582950052 ns/iter 7.492047475042978 ns/iter 0.86
JSON_String_Equal/100 7.356184259454569 ns/iter 7.104273555886896 ns/iter 1.04
JSON_String_Equal_Small_By_Perfect_Hash/10 0.917825562280478 ns/iter 1.0759198017829916 ns/iter 0.85
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 4.129035404480133 ns/iter 4.570311255088117 ns/iter 0.90
JSON_String_Fast_Hash/10 2.0771117201140563 ns/iter 2.409790417932012 ns/iter 0.86
JSON_String_Fast_Hash/100 2.1259514039171195 ns/iter 2.356632183413976 ns/iter 0.90
JSON_String_Key_Hash/10 1.6275261451422347 ns/iter 1.9105988620708314 ns/iter 0.85
JSON_String_Key_Hash/100 2.8836761142577485 ns/iter 3.749163677724451 ns/iter 0.77
JSON_Object_Defines_Miss_Same_Length 2.0154470976636674 ns/iter 2.6192998811396384 ns/iter 0.77
JSON_Object_Defines_Miss_Too_Small 1.9858852000815166 ns/iter 2.56671436106482 ns/iter 0.77
JSON_Object_Defines_Miss_Too_Large 2.0129145694901274 ns/iter 2.7952486493968927 ns/iter 0.72
Pointer_Object_Traverse 61.45893496332181 ns/iter 70.51230673037058 ns/iter 0.87
Pointer_Object_Try_Traverse 45.565740095164465 ns/iter 54.748954536908315 ns/iter 0.83
Pointer_Push_Back_Pointer_To_Weak_Pointer 200.11958305428274 ns/iter 219.29874996313671 ns/iter 0.91
Pointer_Walker_Schema_ISO_Language 5757140.663434874 ns/iter 5503773.6892700195 ns/iter 1.05
Schema_Frame_WoT_References 5840915.553974655 ns/iter 7192872.46465683 ns/iter 0.81
Schema_Frame_OMC_References 30035040.59531472 ns/iter 37536382.6751709 ns/iter 0.80
Schema_Frame_OMC_Locations 30006637.573242188 ns/iter 31586717.156802908 ns/iter 0.95
Schema_Frame_ISO_Language_Locations 118883490.56243896 ns/iter 146917859.71323648 ns/iter 0.81
Schema_Iterator_ISO_Language 1999990.5402615943 ns/iter 2656661.8417640286 ns/iter 0.75
Schema_Frame_ISO_Language_Locations_To_JSON 166315841.6748047 ns/iter 206152737.14065552 ns/iter 0.81
Schema_Tracker_ISO_Language 44092212.404523574 ns/iter 58159093.062082924 ns/iter 0.76
Schema_Tracker_ISO_Language_To_JSON 26319421.254671536 ns/iter 30735546.89233953 ns/iter 0.86
Schema_Format_ISO_Language_To_JSON 112553119.65942383 ns/iter 141321241.85562134 ns/iter 0.80
Schema_Bundle_Meta_2020_12 1773051.7409989054 ns/iter 2084765.8677534624 ns/iter 0.85
Schema_Frame_Many_Resources_References 462895035.7437134 ns/iter 433928966.5222168 ns/iter 1.07
Alterschema_Check_Readibility_ISO_Language_Set_3 165066063.40408325 ns/iter 230928977.33052573 ns/iter 0.71
Alterschema_Check_Readibility_OMC 33816235.40605818 ns/iter 42046701.20688046 ns/iter 0.80
EditorSchema_ForEditor_EmbeddedResources 13515396.91289266 ns/iter 15227618.424788766 ns/iter 0.89
URITemplateRouter_Create 16932.675262185054 ns/iter 16765.41775036212 ns/iter 1.01
URITemplateRouter_Match 227.37455644316054 ns/iter 214.57771492410163 ns/iter 1.06
URITemplateRouterView_Restore 11686.31002512674 ns/iter 12776.606464209639 ns/iter 0.91
URITemplateRouterView_Match 120.58200123204958 ns/iter 137.2508474059097 ns/iter 0.88

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants