-
-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade Core to 4e9d280a8a452885c7cd2bc488799a4f6410f4d8
#17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Juan Cruz Viotti <[email protected]>
🤖 Augment PR SummarySummary: This PR updates the vendored Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| callback(entry_pointer, rule->name(), rule->message(), outcome); | ||
| continue; | ||
| } | ||
| rule->transform(current, outcome); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SchemaTransformer::apply() no longer catches SchemaAbortError around rule->transform(...), so a non-fixable rule (default SchemaTransformRule::transform) will now abort the whole apply instead of being reported via the callback/result. This changes the error-handling contract and could turn previously recoverable transform failures into hard failures.
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| } | ||
| const auto source_location{frame.traverse( | ||
| source_pointer.initial(), | ||
| sourcemeta::core::SchemaFrame::LocationType::Subschema)}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reachability check only calls frame.traverse(..., LocationType::Subschema) for both reference sources and definition entries; if a referenced schema is framed as a Resource (or otherwise not present as a Subschema location), this may treat a reachable reference as unreachable and incorrectly delete a referenced definition.
Other Locations
vendor/core/src/extension/alterschema/common/orphan_definitions.h:111
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti [email protected]