Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 16, 2026

Signed-off-by: Juan Cruz Viotti [email protected]

@augmentcode
Copy link

augmentcode bot commented Jan 16, 2026

🤖 Augment PR Summary

Summary: This PR expands IR compilation test coverage by asserting that known invalid/unsupported schemas fail with the expected exception types.

Changes:

  • Added test/ir/ir_test.cc with focused EXPECT_THROW cases for unsupported dialects, unsupported keywords, invalid keyword values, and unsupported schema shapes.
  • Updated test/ir/CMakeLists.txt to build the new IR unit test source.

Technical Notes: The new tests validate the stability of error contracts across SchemaVocabularyError, UnsupportedKeywordError, UnsupportedKeywordValueError, and UnexpectedSchemaError.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit e07c06e into main Jan 16, 2026
12 checks passed
@jviotti jviotti deleted the error-tests branch January 16, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants