chore(deps): update dependency eslint to v10#3573
chore(deps): update dependency eslint to v10#3573renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
9eef386 to
2f2257c
Compare
4446b13 to
1f8f418
Compare
| "coveralls": "^3.1.1", | ||
| "cross-env": "^10.0.0", | ||
| "eslint": "^9.9.0", | ||
| "eslint": "^10.0.0", |
There was a problem hiding this comment.
Bug: The update to ESLint v10 is missing the required @eslint/js package in devDependencies, which is imported by the ESLint configuration, causing build and lint failures.
Severity: CRITICAL
Suggested Fix
Add the @eslint/js package to the devDependencies in package.json. The version should align with the eslint version, so "@eslint/js": "^10.0.0" is recommended.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L159
Potential issue: The pull request upgrades `eslint` to version 10 but does not add the
`@eslint/js` package to `devDependencies`. ESLint v10 requires this package to be
installed separately. The project's configuration file, `eslint.config.mjs`, explicitly
imports `@eslint/js`. Consequently, when the CI runs `yarn run eslint` or a developer
runs `yarn start` or `yarn build`, the process will fail with a "module not found" error
because the required dependency is not installed. This will block linting, local
development, and production builds.
Did we get this right? 👍 / 👎 to inform future reviews.
62b555b to
f7e1792
Compare
271aadd to
469b771
Compare
| "cross-env": "^10.0.0", | ||
| "eslint": "^9.9.0", | ||
| "eslint": "^10.0.0", | ||
| "eslint-plugin-react": "^7.35.0", |
There was a problem hiding this comment.
Bug: Upgrading to ESLint v10 without updating eslint-plugin-react will cause a runtime crash because the plugin uses a removed API, context.getFilename().
Severity: CRITICAL
Suggested Fix
Update the eslint-plugin-react package to a version that is compatible with ESLint v10. This will likely require a major version bump of the plugin to one that replaces the deprecated context.getFilename() call with the new context.filename property.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L160
Potential issue: The upgrade of ESLint to version 10 introduces a breaking change by
removing the `context.getFilename()` method, which is still used by the currently
installed version of `eslint-plugin-react` (^7.35.0). Because the project's
configuration actively uses this plugin, any command that invokes ESLint, such as the CI
pipeline's linting step or the local `yarn format` script, will fail. This will result
in a `TypeError: contextOrFilename.getFilename is not a function` error, crashing the
process and blocking both continuous integration and local development workflows.
a2a7c05 to
ae58065
Compare
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "@eslint-community/regexpp@npm:^4.12.1": | ||
| version: 4.12.1 | ||
| resolution: "@eslint-community/regexpp@npm:4.12.1" | ||
| checksum: 10c0/a03d98c246bcb9109aec2c08e4d10c8d010256538dcb3f56610191607214523d4fb1b00aa81df830b6dffb74c5fa0be03642513a289c567949d3e550ca11cdf6 | ||
| languageName: node | ||
| linkType: hard | ||
|
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
0bafc9d to
a2c4f32
Compare
a2c4f32 to
a89fb9d
Compare
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
^9.9.0→^10.0.0Release Notes
eslint/eslint (eslint)
v10.0.2Compare Source
v10.0.1Compare Source
Bug Fixes
c87d5bdfix: update eslint (#20531) (renovate[bot])d841001fix: updateminimatchto10.2.1to address security vulnerabilities (#20519) (루밀LuMir)04c2147fix: update error message for unused suppressions (#20496) (fnx)38b089cfix: update dependency @eslint/config-array to ^0.23.1 (#20484) (renovate[bot])Documentation
5b3dbcedocs: add AI acknowledgement section to templates (#20431) (루밀LuMir)6f23076docs: toggle nav in no-JS mode (#20476) (Tanuj Kanti)b69cfb3docs: Update README (GitHub Actions Bot)Chores
e5c281fchore: updates for v9.39.3 release (Jenkins)8c3832achore: update @typescript-eslint/parser to ^8.56.0 (#20514) (Milos Djermanovic)8330d23test: add tests for config-api (#20493) (Milos Djermanovic)37d6e91chore: remove eslint v10 prereleases from eslint-config-eslint deps (#20494) (Milos Djermanovic)da7cd0erefactor: cleanup error message templates (#20479) (Francesco Trotta)84fb885chore: package.json update for @eslint/js release (Jenkins)1f66734chore: addeslinttopeerDependenciesof@eslint/js(#20467) (Milos Djermanovic)v10.0.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.