Skip to content

changes#21

Open
gnuoyohes wants to merge 2 commits into
sonyccd:masterfrom
gnuoyohes:master
Open

changes#21
gnuoyohes wants to merge 2 commits into
sonyccd:masterfrom
gnuoyohes:master

Conversation

@gnuoyohes

Copy link
Copy Markdown
  1. fixed bug where motors would move weirdly or hang when commands were incoming at too high of a frequency
    • created Movement class to handle executing incoming velocity commands
    • cmd_vel_callback now only sets the Movement's twist field
    • calls to the roboclaw_driver are now in the Node's run loop, preventing multiple callbacks trying to execute simultaneously
  2. added pub_odom and stop_movement params for extra configurability
  3. fixed typos 💯

@humbertgim humbertgim left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes solves most of the problems due to writing asynchronously to the serial port. I'm still battling to find a solution for the main loop to get stuck for no apparent reason

@sonarqubecloud

sonarqubecloud Bot commented Aug 9, 2024

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants