Fail-closed trust proxy: default TRUST_PROXY=false and test - #1265
Open
DNight-King wants to merge 2 commits into
Open
Fail-closed trust proxy: default TRUST_PROXY=false and test#1265DNight-King wants to merge 2 commits into
DNight-King wants to merge 2 commits into
Conversation
|
@DNight-King Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1109
Change: default TRUST_PROXY to false so X-Forwarded-For / X-Real-IP are ignored unless TRUSTED_PROXY_CIDRS is explicitly configured.\n\nTest: adds a focused unit test asserting Config::from_env() defaults (TRUST_PROXY == false and TRUSTED_PROXY_CIDRS empty).\n\nFiles changed:\n- services/api/src/config.rs\n- services/api/tests/security_tests.rs\n\nHow to test locally:\n- cd services/api\n- cargo test trust_proxy_defaults_to_false\n\nCloses: #1109