Fix/tts service sends no http security headers no he - #1261
Open
Conversation
tsconfig included src with no exclude, so src/__tests__ was compiled
into dist/__tests__. Jest then matched the emitted server.test.d.ts as
a suite with no tests, failing the run even though all 16 tests passed:
FAIL dist/__tests__/server.test.d.ts
- Your test suite must contain at least one test.
Exclude tests from the build, and add testPathIgnorePatterns for /dist/
so a stale dist cannot break the suite again. Tests remain typechecked:
ts-jest typechecks them at run time.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`npx tsc --noEmit` and `npm run build` were already failing on main:
src/tracing.ts(21,19): error TS2693: 'Resource' only refers to a
type, but is being used as a value here.
src/tracing.ts(28,9): error TS2353: 'ignoreIncomingPaths' does not
exist in type 'HttpInstrumentationConfig'.
The installed OTel v2 packages dropped both APIs: @opentelemetry/resources
now exports Resource as a type only (use resourceFromAttributes), and
instrumentation-http replaced ignoreIncomingPaths with the
ignoreIncomingRequestHook predicate. Port both call sites.
Unrelated to the security-headers change, but required for the PR
checklist's zero-warning build.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Testing Done
Bundle Size
Checklist
docs/architecture.mdRelated Issues
Closes #1219