Fix - use enabled instead of enable-all for java 17 runtime telemetry#446
Merged
cleverchuk merged 1 commit intomainfrom Mar 18, 2026
Merged
Fix - use enabled instead of enable-all for java 17 runtime telemetry#446cleverchuk merged 1 commit intomainfrom
enabled instead of enable-all for java 17 runtime telemetry#446cleverchuk merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the Java 17 runtime telemetry configuration from
enable-alltoenabled, so that only additional JFR-sourced metrics are collected instead of duplicating metrics already available via JMX.Details
The
SolarwindsPropertiesSupplierclass supplies default OpenTelemetry configuration properties when the agent is enabled. One of these properties controls the Java 17 runtime telemetry instrumentation.The previous property key
otel.instrumentation.runtime-telemetry-java17.enable-allactivates all JFR-based runtime metrics, including those that overlap with metrics already collected through JMX. This results in redundant data collection for metrics that JMX already provides.The new property key
otel.instrumentation.runtime-telemetry-java17.enabledactivates only the supplemental JFR metrics that are not available via JMX, avoiding the duplication.One trade-off is that
jvm.system.cpu.utilizationwill no longer be available, as it is only exposed through theenable-allconfiguration. However, reverting toenable-alljust for that metric would re-introduce the full set of duplicate JMX metrics, which is not what we want. Hence, we should remove it from the dashboard.Test services data