Skip to content

Internal - Migrate joboe#433

Merged
cleverchuk merged 2 commits intomainfrom
cc/NH-101163
Mar 17, 2026
Merged

Internal - Migrate joboe#433
cleverchuk merged 2 commits intomainfrom
cc/NH-101163

Conversation

@cleverchuk
Copy link
Contributor

@cleverchuk cleverchuk commented Mar 4, 2026

No description provided.

@cleverchuk cleverchuk requested review from a team as code owners March 4, 2026 20:44
cheempz
cheempz previously approved these changes Mar 5, 2026
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cleverchuk cleverchuk requested a review from cheempz March 12, 2026 13:27
@cleverchuk cleverchuk changed the base branch from joboe-decom to main March 12, 2026 13:38
@cleverchuk cleverchuk dismissed cheempz’s stale review March 12, 2026 13:38

The base branch was changed.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 12, 2026
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@cleverchuk cleverchuk changed the title migrated joboe Internal - Migrate joboe Mar 12, 2026
@cleverchuk cleverchuk force-pushed the cc/NH-101163 branch 2 times, most recently from f17c89b to b2c8255 Compare March 12, 2026 18:44
cheempz
cheempz approved these changes Mar 13, 2026
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but very much "looking" not "reviewing" ;) There were CodeQL findings https://github.com/solarwinds/apm-java/runs/66999829386?pr=433 but nothing that jumped out at me.

One question, would this require any change to the diagnostic tool command?

@cleverchuk
Copy link
Contributor Author

cleverchuk commented Mar 17, 2026 •
edited
Loading

LGTM but very much "looking" not "reviewing" ;) There were CodeQL findings https://github.com/solarwinds/apm-java/runs/66999829386?pr=433 but nothing that jumped out at me.

i'll deal with those in a follow-up. a good chunk is about deprecated code and on generated code.

One question, would this require any change to the diagnostic tool command?

no, i didn't change the package name this time 😅

@cleverchuk cleverchuk merged commit 4a3af30 into main Mar 17, 2026
17 checks passed
@cleverchuk cleverchuk deleted the cc/NH-101163 branch March 17, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheempz cheempz cheempz approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cleverchuk @cheempz