Reestablish completeness check for unlimited body reader#369
Open
alexbiehl wants to merge 2 commits intosnoyberg:masterfrom
Open
Reestablish completeness check for unlimited body reader#369alexbiehl wants to merge 2 commits intosnoyberg:masterfrom
alexbiehl wants to merge 2 commits intosnoyberg:masterfrom
Conversation
added 2 commits
October 25, 2018 15:55
This must have gone missing at some point.
194670d to
02d823d
Compare
sol
requested changes
Mar 22, 2025
Collaborator
sol
left a comment
There was a problem hiding this comment.
- rebase
- s/completeness/completion/ in commit message ("completeness check" is easily confused with other concepts)
- test case for that the cleanup action is never called more than once
| else do | ||
| bs <- connectionRead | ||
| when (S.null bs) $ writeIORef icomplete True | ||
| return bs |
Collaborator
There was a problem hiding this comment.
By now we have:
http-client/http-client/Network/HTTP/Client/Body.hs
Lines 108 to 119 in ed974a7
Given the cleanup action , I think this is even more crucial now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This must have gone missing at some point.