Changed default diagonalization_method to shur_forcedtriu in DORT#71
Open
ECCCBen wants to merge 1 commit intosmrt-model:masterfrom
Open
Changed default diagonalization_method to shur_forcedtriu in DORT#71ECCCBen wants to merge 1 commit intosmrt-model:masterfrom
ECCCBen wants to merge 1 commit intosmrt-model:masterfrom
Conversation
Member
|
Need to adapt the documentation of the dort.py module accordingly to this change, but I'm still not sure we are ready to move to this option, as discussed in the issue #70 . Wait for a few days if the community contributes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70
Changed default
diagonalization_method="shur_forcedtriu"in rtsolver dort.py to fix the convergence issues when simulating backscatter.