v2 breaking change and refactor#318
Open
smlx wants to merge 10 commits into
Open
Conversation
Replace beeep with a much simpler, linux-only notify package, and with the new package implement notification closing after touch. Implement a wait-for-device command that will cause piv-agent to wait for a yubikey device to be plugged in before exiting. The user will be notified and can optionally dismiss the notification to cancel and fall back to the keyfile immedately This gives a user a chance to plug in device before falling back to the keyfile. This can be used in e.g. git's defaultKeyCommand script. Also add some documentation.
* remove all support * update documentation
1. Previously the age handler would try to load a seed file during HandleIdentity. If it wasn't available it would return an error to age and decryption would fail completely. Fix this by moving seed loading to Unwrap(). 2. In Unwrap, return errors wrapping age.ErrIncorrectIdentity. This allows age to continue trying the decryption with another identity. 3. Don't return early if a stanza doesn't match the identity. Instead, check _all_ the stanzas!
Also move the seed fetch earlier out of the loop.
age identities are now 1:1 with slots. Seeds are generated and linked to a slot on a 1:1 basis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major refactor and breaking changes in no particular order:
Fixes: #223
Fixes: #313