fix: support one-off charging profile timers - #640
Open
ethanhawkes-gif wants to merge 1 commit into
Open
Conversation
ethanhawkes-gif
marked this pull request as ready for review
August 2, 2026 16:49
Contributor
|
Thanks for your PR! The code itself looks good, but can you add the errored API-reply from #631 as a fixture? |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #631.
ONE_OFFcharging timers containoneOffDayand omitrecurringOn, butChargingTimers.recurring_onwas required. That made the reporter's charging-profile response fail during deserialization.This change adds the
oneOffDaymapping, makes the two day selectors optional, omits the unused selector on serialization, and preserves the API'sHH:MMtime format for both recurring and one-off timers.Validation:
uv lock --checkpassedOne theoretical edge remains: a malformed timer with neither day selector can deserialize, but its by-alias time serialization falls back to
HH:MM:SS. I did not find this shape in the issue payload or open work; happy to enforce that invariant here if preferred.