docs(design): RFC for companion-set deploy#360
Open
Cre-eD wants to merge 1 commit into
Open
Conversation
Design doc for deploying a stack together with its required companion stacks (inferred from the reverse dependencies.owner edges) as one ordered, fail-closed transaction -- so deploying an owner stack cannot silently strand a companion worker/scheduler that shares its queue. Generalizes the two-tier CI-chaining mitigation to N-tier and to the direct `sc deploy` path. Signed-off-by: Dmitrii Creed <creeed22@gmail.com>
Cre-eD
requested review from
Laboratory,
smecsia and
universe-ops
as code owners
Semgrep Scan ResultsRepository:
Scanned at 2026-07-10 15:32 UTC |
Security Scan ResultsRepository:
Scanned at 2026-07-10 15:32 UTC |
📊 Statement coverageMeasured on the documented included set (see
Baseline: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
docs/design/companion-set-deploy/README.md.Design doc for deploying a stack together with its required companion stacks as one ordered, fail-closed transaction. The companion set is inferred from the reverse
dependencies.owneredges SC already loads (ReadStacks), deployed owner-first (topological), via a thinDeploySet()over the existingDeploy(); a partial set exits non-zero.Why: with the imperative per-stack model, deploying an owner stack (web/API) without its companion (a singleton worker/scheduler sharing the same queue via
dependencies) silently strands the env with no consumer/periodic processor — owner health stays green and there's no worker Deployment to alarm on. CIneeds:-chaining mitigates the two-tier case but only on the CI path and doesn't model multi-companion DAGs; this closes it at the platform layer and on the directsc deploypath.Docs-only (no code); the implementation is scoped in the Rollout section (behind
--with-companionsfirst).