feat: journal: accept _ and ' as digit group marks (#273, #1489) - #2679
Merged
Conversation
…imonmichael#1489) AI usage: Claude Opus 5, ~41k output tokens.
simonmichael
added
journal
simonmichael
added a commit
that referenced
this pull request
Aug 2, 2026
Owner
|
Thank you! |
simonmichael
pushed a commit
that referenced
this pull request
Aug 2, 2026
…counts [#2679] When reviewing a long chart of accounts, clicking an account reloaded the page scrolled to the top, so the sidebar jumped back to the top and you lost your place while working down the account list. The sidebar and the main content now scroll independently (on wider screens), so the window itself doesn't scroll, and the sidebar's scroll position is remembered across navigations (per-tab, in sessionStorage). The account you clicked stays exactly where it was. This is most noticeable with a long account list, and/or long transaction lists, where both panes extend below the viewport. AI usage: Claude Opus 4.8, ~1M output tokens
simonmichael
pushed a commit
that referenced
this pull request
Aug 2, 2026
…nt [#2679] Restoring from $(document).ready caused a visible stutter on pages with a long journal/register: hledger.js loads at the end of the body and ready fires only after the whole document is parsed, while the browser paints the sidebar (at scroll position 0) much earlier, so the sidebar appeared at the top of the account list and then visibly jumped down to the restored position. Restore instead from an inline script right after the sidebar's markup in default-layout.hamlet: it runs mid-parse, before the sidebar is first painted, so the sidebar always appears directly at the restored position. Also set the flag that ignores the restore's own scroll event only when the restore actually moved the sidebar, so it can't swallow the user's first real scroll on pages where no scroll event fires. When reviewing a long chart of accounts, clicking an account reloaded the page scrolled to the top, so the sidebar jumped back to the top and you lost your place while working down the account list. The sidebar and the main content now scroll independently (on wider screens), so the window itself doesn't scroll, and the sidebar's scroll position is remembered across navigations (per-tab, in sessionStorage). The account you clicked stays exactly where it was. This is most noticeable with a long account list, and/or long transaction lists, where both panes extend below the viewport. AI usage: Claude Fable 5, (estimate included in previous commit message)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for underscores and apostrophies as digit group marks. I've added tests where I deemed them relevant, please let me know if you'd like to see tests added in other places (or any other changes I should make)
Closes #273, #1489.
side note: I haven't used any AI generated code in the commit per your policy for first time contributors. I have however used Claude to review my code and have added that as AI usage to my commit message