imp: roi: backport TWR changes from hledger2 - #2678
Merged
Merged
Conversation
Fixes simonmichael#2415 Also includes changes to make `--pnl` optional from simonmichael#2677 which I hope would be accepted into `hledger2` This is a straighforward copy from hledger2 sources with minimal edits to remove queryExpandCurAliases and defaultMaxDisplayPrecision which are not present (or have different name) in hledger1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2415
Also includes changes to make
--pnloptional from #2677, which I hope would be accepted intohledger2This is a straightforward copy from hledger2 sources with minimal edits to remove
queryExpandCurAliases(not present in hledger1 as far as I can tell) and renamedefaultMaxDisplayPrecisiontodefaultMaxPrecision