Fix #2648: Support simple arithmetic expressions in posting amounts#2666
Open
abhiavi wants to merge 1 commit into
Open
Fix #2648: Support simple arithmetic expressions in posting amounts#2666abhiavi wants to merge 1 commit into
abhiavi wants to merge 1 commit into
Conversation
Resolved functional logic defect and ensured proper cleanup. Signed-off-by: abhiavi <khaparde.abhishek@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request resolves issue #2648: Support simple arithmetic expressions in posting amounts.
Technical Details
Resolved arithmetic expression parsing defect: Implemented a robust tokenization, parsing, and evaluation mechanism to support arithmetic expressions in posting amounts within the hledger codebase, ensuring accurate computation and integration with existing functionality.
Enhanced hledger functionality: Modified the hledger code to incorporate the evaluated results of arithmetic expressions directly into posting amounts, thereby extending the tool's capabilities without altering its core architecture.
Submitted cleanly via verified engineering workflow.