Skip to content

fix(code-preview): update overflow to auto IX-4305#2599

Open
alexkaduk wants to merge 3 commits into
mainfrom
feature/IX-4305
Open

fix(code-preview): update overflow to auto IX-4305#2599
alexkaduk wants to merge 3 commits into
mainfrom
feature/IX-4305

Conversation

@alexkaduk

@alexkaduk alexkaduk commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

💡 What is the current behavior?

Preview example pages in all five test apps set overflow: hidden on the html element in global.css. When example content exceeds the viewport (common in embedded code previews), overflow is clipped and the page cannot be scrolled.

GitHub Issue Number: IX-4305 (branch feature/IX-4305)

🆕 What is the new behavior?

  • html { overflow: hidden; } is changed to overflow: auto in src/preview-examples/global.css across all test apps.
  • Tall or wide preview content can scroll instead of being cut off.
  • The same one-line CSS change is applied consistently in:
    • packages/html-test-app
    • packages/react-test-app
    • packages/vue-test-app
    • packages/angular-test-app
    • packages/angular-standalone-test-app

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented — N/A (CSS scroll behavior only; no new a11y API)
  • 🗺️ Internationalization (i18n) - no hard coded strings — N/A
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully — scroll now available when preview content overflows the viewport
  • 📕 Add or update a Storybook story — N/A
  • 📄 Documentation was reviewed/updated siemens/ix-docs — N/A (test-app preview CSS only)
  • 🧪 Unit tests were added/updated and pass (pnpm test) — N/A
  • 📸 Visual regression tests were added/updated and pass (Guide) — N/A
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

@changeset-bot

changeset-bot Bot commented Jun 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4a92b46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Jun 13, 2026

Copy link
Copy Markdown

Deploy Preview for ix-storybook canceled.

Name Link
🔨 Latest commit 4a92b46
🔍 Latest deploy log https://app.netlify.com/projects/ix-storybook/deploys/6a3429048066ca0008603cab

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/IX-4305

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the global CSS across multiple test applications (Angular Standalone, Angular, HTML, React, and Vue) by changing the html element's overflow property from hidden to auto. The reviewer correctly pointed out that combining width: 100vw with overflow: auto triggers an unwanted horizontal scrollbar when vertical scrolling is active, as 100vw includes the scrollbar width. To fix this layout issue, it is recommended to change width: 100vw to width: 100%.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/angular-test-app/src/preview-examples/global.css
Comment thread packages/html-test-app/src/preview-examples/global.css
Comment thread packages/react-test-app/src/preview-examples/global.css
Comment thread packages/vue-test-app/src/preview-examples/global.css
@alexkaduk alexkaduk marked this pull request as ready for review June 18, 2026 17:21
@sonarqubecloud

Copy link
Copy Markdown

@flxlst09 flxlst09 added this to the 5.1.0 milestone Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants