-
Notifications
You must be signed in to change notification settings - Fork 134
core(menu): Implement w3c menu pattern for ix-menu #2573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lzeiml
wants to merge
41
commits into
main
Choose a base branch
from
feat/4304-menu-a11y
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
0a3a8e7
menu pattern implementation
lzeiml 41557c5
fix
lzeiml a33c80f
build
lzeiml 47e4262
restructure
lzeiml 5e06b44
ux changes
lzeiml 7e582f5
remove menu outline
lzeiml fa15bfe
add overflow keyboard scrolling
lzeiml fe83e02
fix
lzeiml aa301a0
a11y fixes
lzeiml 60c1be1
a11y violation fixes
lzeiml e248e05
remove useless padding
lzeiml bc0144c
fixes
lzeiml d55e217
fixes
lzeiml b4bbe35
Merge branch 'main' into feat/4304-menu-a11y
lzeiml 575e9ae
fix
lzeiml 1eef12b
Merge branch 'main' into feat/4304-menu-a11y
lzeiml b3c7f9b
Merge branch 'feat/4304-menu-a11y' of https://github.com/siemens/ix iโฆ
lzeiml 7cdff0b
Enhance ix-menu accessibility with W3C pattern
lzeiml ee252ec
fixes
lzeiml e87e87a
fix
lzeiml 06068ec
a11y improvements
lzeiml b0def67
a11y improvement
lzeiml 58cbcc2
a11y improvements
lzeiml b4a95eb
fix build
lzeiml 18d23df
fix test
lzeiml a0b37f7
actually fix test
lzeiml b2e1958
fix aria-posinset, aria-setsize for menu-category
lzeiml 5fff0ee
fix
lzeiml afd7a2d
label fix
lzeiml 7b21efa
restore focus to menu when closing overlay
lzeiml ddc1994
overlay close focus restore test
lzeiml 2b6a0d7
add since tags
lzeiml 3838043
remove unused state variable
lzeiml f7aef2e
Merge branch 'main' into feat/4304-menu-a11y
lzeiml 0f2746b
build
lzeiml a80ba83
Merge branch 'main' into feat/4304-menu-a11y
lzeiml e604bfc
regression test
lzeiml 4092abc
restore link wrapping
lzeiml ea1157b
fix edge case when menu-category is already expanded
lzeiml 08099e8
fix changeset
lzeiml 2557a18
fix unit
lzeiml File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@siemens/ix': minor | ||
| --- | ||
|
|
||
| Improved **ix-menu** accessibility by implementing the W3C menubar pattern, adding better keyboard navigation and screenreader suppport. | ||
| Added properties `i18nAriaLabelMenu` and `i18nNavigationHint` for screenreader translations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.